Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statsmodels.stats.proportion.proportions_chisquare_allpairs has hardcoded value #1493

Closed
mtrbean opened this issue Mar 19, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@mtrbean
Copy link

commented Mar 19, 2014

This should be a quick fix:

all_pairs = zip(*np.triu_indices(4, 1))

should be

all_pairs = zip(*np.triu_indices(len(count), 1))

@josef-pkt josef-pkt added this to the 0.5.1 milestone Mar 19, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Mar 19, 2014

Thanks @mtrbean

clearly a bug, there is only one test case and that has 4 values.

aside: the smprop.proportions_chisquare_pairscontrol test case doesn't check that the multiple testing p-value correction has the correct values, only raw p-values have a test.

proportions_chisquare_allpairs also has verified numbers for 'holm' corrected p-values

josef-pkt added a commit to josef-pkt/statsmodels that referenced this issue Apr 20, 2014

josef-pkt added a commit to josef-pkt/statsmodels that referenced this issue Apr 20, 2014

josef-pkt added a commit that referenced this issue Apr 21, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.