build_win_bdist*_py3*.bat are using the wrong compiler #1565

Closed
bashtage opened this Issue Apr 6, 2014 · 7 comments

Projects

None yet

2 participants

@bashtage
Contributor
bashtage commented Apr 6, 2014

I'm not sure if these are in actual use or not, but the compiler for the Python 3 builds should be

CALL C:\Program Files\Microsoft SDKs\Windows\v7.1\Bin\SetEnv.cmd /x64 /release

so that MSOC v16, the is used. The current version uses the v15 compiler, which is the compiler for Python 2.

@jseabold
Member
jseabold commented Apr 6, 2014

Did you try to install them and it failed?

AFAIK, all that matter is that it's the .NET framework 4 vs. 3.5 for Python 2.

http://statsmodels.sourceforge.net/devel/install.html#windows

@jseabold
Member
jseabold commented Apr 6, 2014

And that's only for 3.3, unless the official Python builds have changed.

@bashtage
Contributor
bashtage commented Apr 6, 2014

I build on windows for 3.3 using MSOC 16. 3.4 is also MSOC 16.

https://github.com/cython/cython/wiki/64BitCythonExtensionsOnWindows

3.2 does appear to be MSOC 15, so only 3.3 and 3.4 are affected.

In theory using the wrong compiler can cause runtime errors. They use different runtimes - the 15 series uses VC9, while the 16 series uses VC10.

@jseabold
Member
jseabold commented Apr 6, 2014

Oh you mean in this repo not the nightly builds? Yeah, that's just a bad copy paste. Fixed in the binary builds.

We didn't target Python >= 3.3 for the last release so it wasn't an issue.

@bashtage
Contributor
bashtage commented Apr 6, 2014

Are the one in the main repo not needed then?

Might be useful to eventually purge code with hard coded paths.

@jseabold
Member
jseabold commented Apr 6, 2014

It's what we were doing the releases from. Unfortunately, that laptop got stolen, but I think the windows side of my desktop has an identical setup. I'm fixing the paths for this repo in a PR now. I'm not against making the repo directory an environmental variable or something so that anyone can build, but we've never had anyone else want to use them.

@jseabold jseabold closed this in 007f5e7 Apr 6, 2014
@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@jseabold jseabold BLD: Fix typo in copy-paste for 3.4 builds. Closes #1565. d942d37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment