docstring for regression.linear_model.RegressionModel.predict() does not match implementation #1614

Closed
chatcannon opened this Issue Apr 20, 2014 · 2 comments

Projects

None yet

2 participants

@chatcannon
Contributor

Docstring says 'params' is optional if the model has not been fit, but the implementation does not allow 'params' to be absent.

@josef-pkt
Member

Thanks, that statement is outdated by a few versions.
(we dropped attaching results to the model instance because of circular reference)
the model predict always requires params, but x/exog is optional.

@chatcannon chatcannon added a commit to chatcannon/statsmodels that referenced this issue May 18, 2014
@chatcannon chatcannon Update docstring of RegressionModel.predict()
Fixes #1614
52b8e33
@josef-pkt
Member

@chatcannon Do you want to open the pull request for your correction

@josef-pkt josef-pkt closed this in #1677 May 20, 2014
@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@chatcannon chatcannon Update docstring of RegressionModel.predict()
Fixes #1614
abfdd2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment