Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: rename jac -> score_obs #1785

Closed
josef-pkt opened this issue Jun 24, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Jun 24, 2014

my original name was jac
now I think score_obs is nicer, and follows the pattern loglike_obs

affects currently discrete and base

@josef-pkt josef-pkt added this to the 0.6 milestone Jul 28, 2014

@jseabold

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

Is there a PR forthcoming for this? If not, I don't think we should hold up the release for it.

@jseabold

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

Not sure this really needed to get in for 0.6 but I made a PR. Do we need to deprecate jac?

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2014

We skip this for 0.6 unless we handle jac as alias.

@jseabold jseabold closed this in 5c41b60 Sep 23, 2014

josef-pkt added a commit that referenced this issue Sep 23, 2014

Merge pull request #1982 from jseabold/jac-rename
REF: Rename jac -> score_obs. Closes #1785.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.