REF: has_constant, k_constant, include implicit constant detection in base #1794

Closed
josef-pkt opened this Issue Jun 26, 2014 · 2 comments

Projects

None yet

1 participant

@josef-pkt
Member

see comments at the end of #1792

RegressionModel does no implicit constant detection.
The data handling code in base only detects explicit constant (and has a bug for multiple zero variance columns

TODO: merge the use of RegressionModel._has_constant, into base.data.ModelData._handle_constant

Note: we will end up with possible repeated matrix_rank calculations that users can avoid by explicitly providing hasconst in the model creation (__init__).

@josef-pkt
Member

I have the PR almost finished and will push tonight.

@josef-pkt josef-pkt referenced this issue Jun 28, 2014
Merged

BUG/ENH: fix and improve constant detection #1797

1 of 4 tasks complete
@josef-pkt
Member

changed in #1797

@josef-pkt josef-pkt closed this Jul 28, 2014
@josef-pkt josef-pkt added this to the 0.6 milestone Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment