Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ REF conf_int and use_t #1812

Closed
josef-pkt opened this issue Jul 8, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@josef-pkt
Copy link
Member

commented Jul 8, 2014

I thought every inferential statistic uses now use_t. However, while cleaning up the docs I saw that LikelihoodModelResults.conf_int has normal distribution hardcoded.

I thought I have generic tests for this. But maybe only for the defaults.

relevant PR is #1189
It didn't change conf_int which is a mistake, but it has unit tests for conf_int. So I guess there is no test case with non-default conf_int.

linear_model.RegressionResults.conf_int uses use_t
code comment: should be obsolete except super LikelihoodModelResults.conf_int doesn't use use_t

reading through the comments in PR1189, I see it was only/mainly for regression, not for all models.
need another round of refactoring to make the missing changes in base and other models.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2014

GEEResults also defines its own conf_int hardcoded for normal distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.