Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG summary2 doesn't propagate/use use_t #1828

Closed
josef-pkt opened this issue Jul 16, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Jul 16, 2014

I'm not sure yet how this works, but I don't see how use_t ("t" or "z") is propagated or used in summary2

found while fixing #1812

It's a bug. See discrete_choice_example.py
print(affair_mod.summary2()) show "t" instead of "z"

@josef-pkt josef-pkt added the comp-io label Jul 16, 2014

@josef-pkt josef-pkt changed the title summary2 doesn't propagate/use use_t BUG summary2 doesn't propagate/use use_t Jul 16, 2014

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

The coef/se/t/ci panel of your ascii summary is a dataframe that is (typically) constructed using a helper function. You need to make sure that your result class' summary method passes the use_t argument down to the summary_params function:

https://github.com/statsmodels/statsmodels/blob/master/statsmodels/iolib/summary2.py#L300

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

But now that I look at summary_params(), I expect you might want it to do something else...

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2014

@vincentarelbundock I changed it here 4b9f7ee
In add_base

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

Cool. I've been debating (internally, in my head) whether having add_base is a good idea. Seems like a wrapper around few things. Might be better to just do it explicitly. Oh well.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2014

It doesn't really matter for this where we do define the argument for use_t.

I'm reusing the paramstable for other things like t_test where we need the use_t option. For the results summary I want to start to hardcore the use of the use_t results attribute.

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.