BUG summary2 doesn't propagate/use use_t #1828

Closed
josef-pkt opened this Issue Jul 16, 2014 · 6 comments

Projects

None yet

2 participants

@josef-pkt
Member

I'm not sure yet how this works, but I don't see how use_t ("t" or "z") is propagated or used in summary2

found while fixing #1812

It's a bug. See discrete_choice_example.py
print(affair_mod.summary2()) show "t" instead of "z"

@josef-pkt josef-pkt added the comp-io label Jul 16, 2014
@josef-pkt josef-pkt changed the title from summary2 doesn't propagate/use use_t to BUG summary2 doesn't propagate/use use_t Jul 16, 2014
@vincentarelbundock
Member

The coef/se/t/ci panel of your ascii summary is a dataframe that is (typically) constructed using a helper function. You need to make sure that your result class' summary method passes the use_t argument down to the summary_params function:

https://github.com/statsmodels/statsmodels/blob/master/statsmodels/iolib/summary2.py#L300

@vincentarelbundock
Member

But now that I look at summary_params(), I expect you might want it to do something else...

@josef-pkt
Member

@vincentarelbundock I changed it here 4b9f7ee
In add_base

@vincentarelbundock
Member

Cool. I've been debating (internally, in my head) whether having add_base is a good idea. Seems like a wrapper around few things. Might be better to just do it explicitly. Oh well.

@josef-pkt
Member

It doesn't really matter for this where we do define the argument for use_t.

I'm reusing the paramstable for other things like t_test where we need the use_t option. For the results summary I want to start to hardcore the use of the use_t results attribute.

@vincentarelbundock
Member

Good idea.

@josef-pkt josef-pkt closed this in 4b9f7ee Jul 18, 2014
@josef-pkt josef-pkt referenced this issue Aug 7, 2014
Merged

BUG/ENH Use t #1830

@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014
@josef-pkt josef-pkt BUG: summary2 use use_t from results closes #1828 de80a69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment