Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not cythonize when cleaning up #1852

Closed
yarikoptic opened this issue Jul 29, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@yarikoptic
Copy link
Contributor

commented Jul 29, 2014

$> python setup.py clean
Cythonizing sources
Processing statsmodels/tsa/kalmanf/kalman_loglike.pyx
Processing statsmodels/nonparametric/_smoothers_lowess.pyx
Processing statsmodels/nonparametric/linbin.pyx
running clean
@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 17, 2014

line 419:

    if not os.path.exists(os.path.join(cwd, 'PKG-INFO')):
        # Generate Cython sources, unless building from source release
        generate_cython()

I think the if here needs more conditions. for example the same as on line 385

if not (len(sys.argv) >= 2 and ('--help' in sys.argv[1:] or
            sys.argv[1] in ('--help-commands', 'egg_info', '--version',
                            'clean'))):

change in 0.6 or in 0.7 ?

@jseabold jseabold added this to the 0.6 milestone Sep 25, 2014

jseabold added a commit to jseabold/statsmodels that referenced this issue Sep 25, 2014

@jseabold jseabold closed this in c2e68e6 Sep 25, 2014

jseabold added a commit that referenced this issue Sep 25, 2014

Merge pull request #2006 from jseabold/fix-cythonize
BLD: Do not generate cython on clean. Closes #1852.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.