Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEE: required attributes missing, df_resid #1918

Closed
josef-pkt opened this issue Aug 20, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@josef-pkt
Copy link
Member

commented Aug 20, 2014

bug or not ?

What are our required attributes?
GEE doesn't define df_resid. as a consequence t_test fails in the unit tests.

I'm just adding GEE to the generic tests in base and get several failures. see #1916

still need to investigate:
does t_test require df_resid even if use_t=False and use_f=False in wald_test?

update
currently t_test requires df_resid or df_resid_inference even if use_t=False
The availability of a df_resid could be made optional, but we use it also for other things. (heuristic for number of constraints in compare_xxx, Kevin has exact check for nested. may not be connected yet to all models.)

ignore for 0.6 or fix?

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 20, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2014

this has been reported already as part of #1257

@josef-pkt josef-pkt closed this in abcf156 Aug 23, 2014

bert9bert added a commit to bert9bert/statsmodels that referenced this issue Aug 29, 2014

yarikoptic added a commit to yarikoptic/statsmodels that referenced this issue Oct 23, 2014

Merge commit 'v0.5.0-1269-g957a43e' into debian-experimental
* commit 'v0.5.0-1269-g957a43e': (59 commits)
  TST: avoid pandas in assert with wrapped results (failure pandas>0.12)
  REF: GEEResults rename to postfix names, keep old as alias for now
  BUG: NominalGEE pandas handling, fix typo, adjust unit tests
  ENH: GEE add Wrapper, closes statsmodels#1904
  BUG: NominalGEE fix initialization for pandas, closes statsmodels#1931
  BUG/ENH: add df_resid, df_model, fixes t_test, closes statsmodels#1918
  REF: GEE rename naive_covariance -> cov_naive, same for others
  REF: rename covariance_type -> cov_type
  TST: test_glm: remove test noise
  BUG: GEE subclasses cov_params_default doesn't get attached, unit tests
  REF: GEE summary remove covariance_type argument (not possible)
  BUG/TST: GEE fix predict closes statsmodels#1919 and fix conf_int for cov_params_default add GEE to generic test, and adjust those (missing _results, summary2)
  BUG: GEE partial cleanup of cov_type, see statsmodels#1906
  ENH: cov_kwds add generic 'scaling_factor' option to match Stata
  BUG: genmod links, CDFLink, probit deriv2 use approx_fprime (not complex)
  BUG: fix used hessian in sandwich_covariance, with GLM test cases
  REF: GLM change default scale in score_obs (tests pass, possibly wrong, see PR comment)
  REF/TST generic cov_type, TST compare GLM Logit, GLM OLS (this fails)
  REF/ENH: add get_robustcov_results generically to LikelihoodModel/Results    NegativeBinomial as test case, needs cleanup for code duplication.
  ENH: add cov_type to GLM.fit, with tests for family Poisson
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.