New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: rlm errors on missing values #2083
Comments
Thanks for the report (unfortunately 0.6 is out) it looks like there is no protection for a empty using arrays also works correctly
|
The fix looks like it should specifically check for empty
aside: an empty list doesn't raise an exception in reduce
|
Looks like OLS always add (adding a raise to get to the right spot with pdb)
|
Yes, that's completely broken
including exposure raises another exception, (same for offset)
it works without formula:
|
Looks like
|
In The following looks a bit ugly (having to attach twice), but it works for me i.e. go through super first and then check_inputs. (super might be raising an exception already if there is a length mismatch - haven't tried yet)
first self. attaching is not necessary, I guess |
simplified
the |
incorrect missing handling in offset and exposure are not really |
I'm fixing these in #2084. |
I leave it for now, and review #2084 when you finished the changes. |
I fixed everything mentioned in here. Let me know any other issues. We'll need a consolidated overhaul for extra data handling to move it all up the class hierarchy at some point. I'm worried about all the special casing that's going in GLM, Discrete, GEE, MixedLM, etc. for formulas and extra arrays, though some of it is unavoidable. I also have been meaning to document for developers what goes on at a high-level in the data handling with the super call. It was clear from recent additions (MixedLM, etc.) that the magic is not clear to anyone else. |
BUG: Correct issue if patsy handles missing. Closes #2083.
Hello,
I just upgraded to statsmodels v. 0.6.0 and found my code was not running as expected compared to v.0.5.0. After somme digging, I narrowed the error to the following problem of rlm with the formula api. Since the missing kwarg is set to 'drop' by default, I'm guessing this is a bug.
which raises the following Exception
The text was updated successfully, but these errors were encountered: