Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowess returns inconsistent with option #922

Closed
josef-pkt opened this issue Jun 28, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@josef-pkt
Copy link
Member

commented Jun 28, 2013

I just saw looking at the code again

if return_sorted or (all_valid and is_sorted):
        return res

if return_sorted is False, then we should return only yfitted not res

I thought I have all major combination of options in the unit tests.

josef-pkt added a commit to josef-pkt/statsmodels that referenced this issue Aug 8, 2013

@josef-pkt josef-pkt closed this in bb1ffdd Aug 14, 2013

jseabold added a commit that referenced this issue Aug 14, 2013

MAINT: Merge branch 'maintenance/0.5.x'. Merge to close issues.
* maintenance/0.5.x:
  BUG: fix warning arguments in GenericLikelihoodModel
  MAINT: Add name to .mailmap.
  ENH: Pandas Series no longer inherits from ndarray. Closes #1036.
  TST: Fixed test for Anaconda on Windows
  TST: Make test compatible with pandas 0.7.x
  BUG: Fail gracefully when not enough obs given for order.
  BUG: Handle non-string names in lag name making.
  TST: Test for issue 1038.
  DOC: fix docstrings so Latex finishes
  REF: add shapes to Transf_gen, small cleanups
  add explicit shapes to TestTransf2: fixes the fail w/scipy PR/2588
  BUG: acorr_breush_godfrey fix nlags choice closes #676
  BUG: return only yfitted if return_sorted is False closes #922
  TST: Add regression test for #1025.
  BUG: Check for 0 variance not unit. Closes #1025.
  BUG: robust.norms.TrimmedMean fix typos in psi_deriv closes #425
  ENH: Bump Python and NumPy versions. Remove 2.5 only code.

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this issue Sep 2, 2014

MAINT: Merge branch 'maintenance/0.5.x'. Merge to close issues.
* maintenance/0.5.x:
  BUG: fix warning arguments in GenericLikelihoodModel
  MAINT: Add name to .mailmap.
  ENH: Pandas Series no longer inherits from ndarray. Closes statsmodels#1036.
  TST: Fixed test for Anaconda on Windows
  TST: Make test compatible with pandas 0.7.x
  BUG: Fail gracefully when not enough obs given for order.
  BUG: Handle non-string names in lag name making.
  TST: Test for issue 1038.
  DOC: fix docstrings so Latex finishes
  REF: add shapes to Transf_gen, small cleanups
  add explicit shapes to TestTransf2: fixes the fail w/scipy PR/2588
  BUG: acorr_breush_godfrey fix nlags choice closes statsmodels#676
  BUG: return only yfitted if return_sorted is False closes statsmodels#922
  TST: Add regression test for statsmodels#1025.
  BUG: Check for 0 variance not unit. Closes statsmodels#1025.
  BUG: robust.norms.TrimmedMean fix typos in psi_deriv closes statsmodels#425
  ENH: Bump Python and NumPy versions. Remove 2.5 only code.

yarikoptic added a commit to yarikoptic/statsmodels that referenced this issue Oct 23, 2014

Merge tag 'v0.5.0' into debian
Version 0.5.0

* tag 'v0.5.0':
  DOC: Update release notes with maint branch changes.
  MAINT: Fix mailmap entry.
  BUG: fix warning arguments in GenericLikelihoodModel
  MAINT: Add name to .mailmap.
  ENH: Pandas Series no longer inherits from ndarray. Closes statsmodels#1036.
  TST: Fixed test for Anaconda on Windows
  TST: Make test compatible with pandas 0.7.x
  BUG: Fail gracefully when not enough obs given for order.
  BUG: Handle non-string names in lag name making.
  TST: Test for issue 1038.
  DOC: fix docstrings so Latex finishes
  REF: add shapes to Transf_gen, small cleanups
  add explicit shapes to TestTransf2: fixes the fail w/scipy PR/2588
  BUG: acorr_breush_godfrey fix nlags choice closes statsmodels#676
  BUG: return only yfitted if return_sorted is False closes statsmodels#922
  TST: Add regression test for statsmodels#1025.
  BUG: Check for 0 variance not unit. Closes statsmodels#1025.
  BUG: robust.norms.TrimmedMean fix typos in psi_deriv closes statsmodels#425
  ENH: Bump Python and NumPy versions. Remove 2.5 only code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.