Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: reg diagnostics #1056

Merged
merged 1 commit into from Aug 26, 2013

Conversation

Projects
None yet
3 participants
@vincentarelbundock
Copy link
Contributor

commented Aug 20, 2013

Regression diagnostics example

http://nbviewer.ipython.org/6283160

example_quantreg was lonely in example/ipynb folder. I moved it to example/notebooks

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 20, 2013

how about starting to use print(blabla) (when it works) pretending to be a function, or actually being a function?
My main notebook version is now in python 3.3, back to the future :)

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

Yes. In fact, most of those print statements can just be removed.

fixed and squashed into single commit.

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2013

I'd like to use my new powers to push this through. I'm unlikely to improve the notebook in the short term, and I've integrated @josef-pkt comments (import stats.api as sms and print()). The only other change is moving the quantreg example notebook which was sitting in the wrong folder.

I tested both example_regression_diagnostic.ipynb and quantreg.ipynb using latest master and they ran fine. The Travis build error is obviously unrelated to this.

I would test docs build but nbgenerate.py still has hardcoded file paths and such, so that'll need to be cleaned up before easy doc build with notebooks is possible.

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2013

Any objections?

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 23, 2013

question about timing

@jseabold are we switching to merge into master and then cherry-pick into maintenance?

otherwise no problem to merge (you can just hit green button)
check network graph: only one commit behind master, so would be ok without rebase

@jseabold

This comment has been minimized.

Copy link
Member

commented Aug 26, 2013

I say merge to master since the examples will get rendered and posted to the dev docs, it's not very critical that they be in the release?

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2013

So merge into master or maintenance?

vincentarelbundock added a commit that referenced this pull request Aug 26, 2013

Merge pull request #1056 from vincentarelbundock/example_regression_d…
…iagnostics

Example: reg diagnostics

@vincentarelbundock vincentarelbundock merged commit d80d414 into statsmodels:master Aug 26, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1056 from vincentarelbundock/example_r…
…egression_diagnostics

Example: reg diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.