Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Deprecate stand_mad. Add center keyword to mad. Closes #658. #1107

Merged
merged 2 commits into from Oct 23, 2013

Conversation

Projects
None yet
4 participants
@jseabold
Copy link
Member

commented Oct 9, 2013

We need to add a version0.6.rst to docs/source/release and note that this change is backwards incompatible. It changes the default behavior of mad, but it changes it something that most people actually expect...

@coveralls

This comment has been minimized.

Copy link

commented Oct 9, 2013

Coverage Status

Coverage remained the same when pulling 9415057 on jseabold:robust-mad-refactor into 3b7082c on statsmodels:master.

@@ -2,7 +2,7 @@
Robust statistical models
"""
import norms
from .scale import mad, stand_mad, Huber, HuberScale, hubers_scale

This comment has been minimized.

Copy link
@rgommers

rgommers Oct 10, 2013

Member

Doesn't this break the API? I think you need to leave it here till you remove it for 0.7

This comment has been minimized.

Copy link
@jseabold

jseabold Oct 10, 2013

Author Member

Good point. Fixed.

@rgommers

This comment has been minimized.

Copy link
Member

commented Oct 10, 2013

+1

@coveralls

This comment has been minimized.

Copy link

commented Oct 10, 2013

Coverage Status

Coverage remained the same when pulling dd5cb3e on jseabold:robust-mad-refactor into 3b7082c on statsmodels:master.

@@ -187,9 +187,10 @@ def _estimate_scale(self, resid):
"""
if isinstance(self.scale_est, str):
if self.scale_est.lower() == 'mad':
return scale.mad(resid)
if self.scale_est.lower() == 'stand_mad':
return scale.stand_mad(resid)

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Oct 23, 2013

Member

I would also deprecate stand_mad here, and keep it as alias for the new mad for one release.

Users that currently use 'mad' explicitly, will have a change of behavior if center is not zero.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Oct 23, 2013

milestone 0.6, not for 0.5.1

@coveralls

This comment has been minimized.

Copy link

commented Oct 23, 2013

Coverage Status

Coverage remained the same when pulling e82c51e on jseabold:robust-mad-refactor into 3b7082c on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2013

Rebased.

jseabold added a commit that referenced this pull request Oct 23, 2013

Merge pull request #1107 from jseabold/robust-mad-refactor
REF: Deprecate stand_mad. Add center keyword to mad. Closes #658.

@jseabold jseabold merged commit ea61f86 into statsmodels:master Oct 23, 2013

@jseabold jseabold deleted the jseabold:robust-mad-refactor branch Oct 23, 2013

@josef-pkt josef-pkt referenced this pull request Jan 24, 2014

Open

perfect fit (in rlm) #55

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1107 from jseabold/robust-mad-refactor
REF: Deprecate stand_mad. Add center keyword to mad. Closes statsmodels#658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.