Added support for pandas when pandas was installed directly from git trunk #1185

Merged
merged 2 commits into from Jan 21, 2014

Projects

None yet

3 participants

@invisibleroads
Contributor

pandas.version == commit_hash when pandas is installed from git trunk

@invisibleroads invisibleroads Added support for pandas installed directly from git trunk
pandas.version == commit_hash when pandas is installed from git trunk
147ce16
@coveralls

Coverage Status

Coverage remained the same when pulling 147ce16 on invisibleroads:patch-1 into 9d4b1f8 on statsmodels:master.

@jseabold
Member

Thanks, looks ok to me, though I don't have a machine handy to look at the pandas dev versioning. What, if anything, changed in pandas that this is no longer working?

@invisibleroads
Contributor

If the user downloads and install pandas using

git clone --depth=1 https://github.com/pydata/pandas/pull/5520

then

pandas.version.version = d250d64 (the commit hash)

while

pandas.version.short_version = 0.12.0
@jseabold
Member

Yes, I'm wondering when this changed. Did your PR change this behavior? For me,

[~/]
[4]: from pandas.version import version as pversion

[~/]                                                                            
[9]: print pversion
0.12.0-1035-g8828dbf

[~/]
[8]: re.match('\d*.\d*.\d*', pversion).group()
[8]: '0.12.0'
@jseabold
Member

I guess the shallow clones don't get the tags. Hmm. That's annoying. Maybe we should just always check short_version instead of a nested try/except.

@invisibleroads
Contributor

Good idea! I updated the pull request to use pandas.version.short_version instead.

@coveralls

Coverage Status

Coverage remained the same when pulling 09f7826 on invisibleroads:patch-1 into 9d4b1f8 on statsmodels:master.

@invisibleroads
Contributor

Hi jseabold, is it possible for you to please merge these changes into master? I just ran into the same error on a fresh installation. For now, my workaround is to run "git fetch --tags" before installing pandas.

@invisibleroads
Contributor

I want to note that installing pandas after running "git fetch --tags" did not resolve the issue. Then there are only two options: 1) install pandas from pypi instead of github 2) modify setup.py in statsmodels manually.

@jseabold jseabold merged commit 2bc4041 into statsmodels:master Jan 21, 2014

1 check passed

default The Travis CI build passed
Details
@jseabold
Member

Yes, sorry. Thanks for the bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment