Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pandas when pandas was installed directly from git trunk #1185

Merged
merged 2 commits into from Jan 21, 2014

Conversation

Projects
None yet
3 participants
@invisibleroads
Copy link
Contributor

commented Nov 15, 2013

pandas.version == commit_hash when pandas is installed from git trunk

Added support for pandas installed directly from git trunk
pandas.version == commit_hash when pandas is installed from git trunk
@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2013

Coverage Status

Coverage remained the same when pulling 147ce16 on invisibleroads:patch-1 into 9d4b1f8 on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member

commented Nov 15, 2013

Thanks, looks ok to me, though I don't have a machine handy to look at the pandas dev versioning. What, if anything, changed in pandas that this is no longer working?

@invisibleroads

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2013

If the user downloads and install pandas using

git clone --depth=1 https://github.com/pydata/pandas/pull/5520

then

pandas.version.version = d250d64 (the commit hash)

while

pandas.version.short_version = 0.12.0
@jseabold

This comment has been minimized.

Copy link
Member

commented Nov 17, 2013

Yes, I'm wondering when this changed. Did your PR change this behavior? For me,

[~/]
[4]: from pandas.version import version as pversion

[~/]                                                                            
[9]: print pversion
0.12.0-1035-g8828dbf

[~/]
[8]: re.match('\d*.\d*.\d*', pversion).group()
[8]: '0.12.0'
@jseabold

This comment has been minimized.

Copy link
Member

commented Nov 17, 2013

I guess the shallow clones don't get the tags. Hmm. That's annoying. Maybe we should just always check short_version instead of a nested try/except.

@invisibleroads

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2013

Good idea! I updated the pull request to use pandas.version.short_version instead.

@coveralls

This comment has been minimized.

Copy link

commented Nov 17, 2013

Coverage Status

Coverage remained the same when pulling 09f7826 on invisibleroads:patch-1 into 9d4b1f8 on statsmodels:master.

@invisibleroads

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2014

Hi jseabold, is it possible for you to please merge these changes into master? I just ran into the same error on a fresh installation. For now, my workaround is to run "git fetch --tags" before installing pandas.

@invisibleroads

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2014

I want to note that installing pandas after running "git fetch --tags" did not resolve the issue. Then there are only two options: 1) install pandas from pypi instead of github 2) modify setup.py in statsmodels manually.

jseabold added a commit that referenced this pull request Jan 21, 2014

Merge pull request #1185 from invisibleroads/patch-1
BLD: Add support for installing when pandas is a shallow clone.

@jseabold jseabold merged commit 2bc4041 into statsmodels:master Jan 21, 2014

1 check passed

default The Travis CI build passed
Details
@jseabold

This comment has been minimized.

Copy link
Member

commented Jan 21, 2014

Yes, sorry. Thanks for the bump.

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1185 from invisibleroads/patch-1
BLD: Add support for installing when pandas is a shallow clone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.