TST: enable tests for llf after change to WLS.loglike see #1170 #1192

Merged
merged 1 commit into from Dec 19, 2013

Projects

None yet

2 participants

@josef-pkt
Member

This enables tests that were commented out.

It is supposed to go in after fixing WLS.loglike as discussed in #1170

I cannot find the commit for WLS.loglike in any of bashtage's PRs right now.
If the change is not included in any of bashtage's PRs, I will make a separate PR, that also fixes the failing tests because we will use a different definition or normalization than Stata.

the tests don't fail with current master:

I had changed GLSAR to subclass GLS instead of WLS which has the correct loglike
GLSHet which subclasses WLS doesn't have unit tests yet. (I didn't find a direct equivalent in Stata or R, IIRC)

@coveralls

Coverage Status

Coverage remained the same when pulling d955aac on josef-pkt:enable_WLS_llf_tests into 9d4b1f8 on statsmodels:master.

@josef-pkt
Member

rebased and force pushed
should be ready to merge when TravisCI comes back green

note: the commit message is a bit misleading because the unit tests don't use WLS, and don't check the change in PR #1253

@coveralls

Coverage Status

Coverage remained the same when pulling 1ac21e4 on josef-pkt:enable_WLS_llf_tests into f974da3 on statsmodels:master.

@josef-pkt josef-pkt merged commit 3f22bc0 into statsmodels:master Dec 19, 2013

1 check passed

default The Travis CI build passed
Details
@josef-pkt josef-pkt deleted the josef-pkt:enable_WLS_llf_tests branch Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment