Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix typo. #1302

Merged
merged 1 commit into from Feb 7, 2014

Conversation

Projects
None yet
4 participants
@jseabold
Copy link
Member

commented Jan 8, 2014

Did anyone actually fix this yet? I couldn't find an issue or PR.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 8, 2014

phobson is preparing a pull request to fix this and other problems/bugs, plus some refactoring,
PR is not yet opened

@coveralls

This comment has been minimized.

Copy link

commented Jan 8, 2014

Coverage Status

Coverage remained the same when pulling 3b5fc99 on jseabold:fix-qntls into f8156e7 on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2014

Any harm in fixing this while we wait?

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2014

@coveralls

This comment has been minimized.

Copy link

commented Jan 9, 2014

Coverage Status

Coverage remained the same when pulling 4d127dd on jseabold:fix-qntls into fe6e688 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 9, 2014

Any harm in fixing this while we wait?

Since it's not the only bug in master, I would wait a day or two, to avoid merge conflicts.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2014

Ok, but it's the one that raises an error.

FWIW, merge conflicts really are pretty trivial to fix. Just remove the lines you don't want for the newer changes and things are pretty seamless after that.

@phobson

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2014

I say so ahead and merge this. I agree that the conflicts would be trivial to deal with. --
Paul Hobson
Sorry if this is unintelligible. I'm on my phone.

On Thu, Jan 9, 2014 at 5:33 AM, Skipper Seabold notifications@github.com
wrote:

Ok, but it's the one that raises an error.

FWIW, merge conflicts really are pretty trivial to fix. Just remove the lines you don't want for the newer changes and things are pretty seamless after that.

Reply to this email directly or view it on GitHub:
#1302 (comment)

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2014

Ok, I'm going to go ahead and merge. Let me know if you have trouble with merge conflicts but should be straightforward one line if git doesn't figure it out automatically. Best to rebase your PR branch on master after this is in.

jseabold added a commit that referenced this pull request Feb 7, 2014

@jseabold jseabold merged commit 39806de into statsmodels:master Feb 7, 2014

1 check was pending

default The Travis CI build is in progress
Details

@jseabold jseabold deleted the jseabold:fix-qntls branch Feb 7, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.