Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Decode metadata to utf-8. Closes #1326. #1329

Merged
merged 1 commit into from Jan 26, 2014

Conversation

Projects
None yet
2 participants
@jseabold
Copy link
Member

commented Jan 25, 2014

No description provided.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 25, 2014

I don't think it closes 1326 yet. There is at least additionally the double decoding when reading from cache.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2014

Can you try it, since I can't reproduce?

Can you point to the double decoding? I don't see what you mean.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 25, 2014

I'm running out the door to a snow festival, I can look into it tonight

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2014

Sure. Sounds good. Have fun!

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2014

@andreas-h Can you give this a whirl? (Or make the changes locally and see if it fixes your problem)

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2014

Sounds like this is alright to merge.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 25, 2014

looks good for this part. only the first commit is necessary.

jseabold added a commit that referenced this pull request Jan 26, 2014

Merge pull request #1329 from jseabold/fix-1326
BUG: Decode metadata to utf-8. Closes #1326.

@jseabold jseabold merged commit 8d7df1a into statsmodels:master Jan 26, 2014

@jseabold jseabold deleted the jseabold:fix-1326 branch Jan 26, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.