Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Always use unicode. #1331

Merged
merged 1 commit into from Jan 26, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Jan 26, 2014

I don't really know why we were only decoding to unicode in Python 3 only. Just make sure that everything is in unicode. Should fix any remaining issues with docstring display.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 26, 2014

Sounds correct to me, if we don't have only ascii or system encoding strings, then we have to take care also of unicode in python 2.

I assume since Vincent works on Linux, all the rdatasets will be utf-8 and we should be fine if we use it everywhere.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2014

Yes, I think all of the docs are HTML in utf-8.

jseabold added a commit that referenced this pull request Jan 26, 2014

@jseabold jseabold merged commit a0fc6d1 into statsmodels:master Jan 26, 2014

1 check passed

default The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:dataset-unicode-docstrings branch Jan 26, 2014

@vincentarelbundock

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2014

Working on a macbook nowadays :) But yes, pretty sure everything should be utf8

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.