ENH: Always use unicode. #1331

Merged
merged 1 commit into from Jan 26, 2014

Projects

None yet

3 participants

@jseabold
Member

I don't really know why we were only decoding to unicode in Python 3 only. Just make sure that everything is in unicode. Should fix any remaining issues with docstring display.

@josef-pkt
Member

Sounds correct to me, if we don't have only ascii or system encoding strings, then we have to take care also of unicode in python 2.

I assume since Vincent works on Linux, all the rdatasets will be utf-8 and we should be fine if we use it everywhere.

@jseabold
Member

Yes, I think all of the docs are HTML in utf-8.

@jseabold jseabold merged commit a0fc6d1 into statsmodels:master Jan 26, 2014

1 check passed

default The Travis CI build passed
Details
@jseabold jseabold deleted the jseabold:dataset-unicode-docstrings branch Jan 26, 2014
@vincentarelbundock
Member

Working on a macbook nowadays :) But yes, pretty sure everything should be utf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment