ENH: Add Bunch object to tools. #1332

Merged
merged 1 commit into from Jan 27, 2014

Projects

None yet

2 participants

@jseabold
Member

Added but didn't replace its usage anywhere in the code with an import yet.

@josef-pkt
Member

having this in a central location is a good idea

my usual comment:

E:\Josef\work-oth2\Stata>"C:\Programs\Python27\python.exe"
Python 2.7.1 (r271:86832, Nov 27 2010, 18:30:46) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> import sys
>>> len(sys.modules)
237
>>> import statsmodels.tools.tools as stt
>>> len(sys.modules)
735
>>> sys.modules
@jseabold
Member

Operating under the assumption that DRY > import pollution. Can clean up things in a separate commit.

@jseabold jseabold merged commit 2a1703f into statsmodels:master Jan 27, 2014

1 check passed

default The Travis CI build passed
Details
@jseabold jseabold deleted the jseabold:add-bunch-obj branch Jan 27, 2014
@josef-pkt
Member

for example put it into a _tools_light.py, and add from _tools_light import Bunch in tools.py
then we get DRY, and no import pollution when that brings an advantage.

@jseabold
Member

Feel free to do this in a tools cleanup commit, but pretty soon we have matlab code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment