Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add Bunch object to tools. #1332

Merged
merged 1 commit into from Jan 27, 2014

Conversation

Projects
None yet
2 participants
@jseabold
Copy link
Member

commented Jan 27, 2014

Added but didn't replace its usage anywhere in the code with an import yet.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 27, 2014

having this in a central location is a good idea

my usual comment:

E:\Josef\work-oth2\Stata>"C:\Programs\Python27\python.exe"
Python 2.7.1 (r271:86832, Nov 27 2010, 18:30:46) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> import sys
>>> len(sys.modules)
237
>>> import statsmodels.tools.tools as stt
>>> len(sys.modules)
735
>>> sys.modules
@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2014

Operating under the assumption that DRY > import pollution. Can clean up things in a separate commit.

jseabold added a commit that referenced this pull request Jan 27, 2014

Merge pull request #1332 from jseabold/add-bunch-obj
ENH: Add Bunch object to tools.

@jseabold jseabold merged commit 2a1703f into statsmodels:master Jan 27, 2014

1 check passed

default The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:add-bunch-obj branch Jan 27, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jan 27, 2014

for example put it into a _tools_light.py, and add from _tools_light import Bunch in tools.py
then we get DRY, and no import pollution when that brings an advantage.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2014

Feel free to do this in a tools cleanup commit, but pretty soon we have matlab code.

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.