Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deprecate rank in favor of np.linalg.matrix_rank #1383

Merged
merged 3 commits into from Apr 3, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Feb 11, 2014

No description provided.

@@ -18,9 +18,8 @@
Chapman & Hall, Boca Rotan.
"""

import numpy as np
import numpy as npmatrix_

This comment has been minimized.

Copy link
@argriffing

This comment has been minimized.

Copy link
@jseabold

jseabold Feb 11, 2014

Author Member

yeesh must've slipped on my keyboard. thanks

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2014

I don't see these failures locally. I'll try to install 1.6.1 locally. I assume matrix_rank is available in our minimum numpy.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Feb 12, 2014

matrix_rank is available in numpy 1.6, but at some point Matthews change the defaults for the threshold. I don't remember if this happened after 1.6, but I think so.
(I have problems looking at TravisCI because I'm using internet explorer.)

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2014

Is 1.6 our minimum version? We list 1.5 on the web...

@argriffing

This comment has been minimized.

Copy link

commented Feb 12, 2014

Looks like its behavior changed in 1.7 or 1.8 numpy/numpy@78b7693

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2014

Thanks. I can replicate one of these failures with 1.6.0. Odd. So I guess this PR is a non-starter? Is it worth writing a wrapper to adjust the tolerance?

@argriffing

This comment has been minimized.

Copy link

commented Feb 12, 2014

The current numpy matrix_rank implementation could be copypasted into statsmodels, with the intention that it would be deleted when the required numpy version reaches 1.7

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2014

We'll see if that works.

@argriffing

This comment has been minimized.

Copy link

commented Feb 13, 2014

if numpy 1.10 is released this will break everyone's version string comparisons ('1.10' < '1.8' < '1.9')

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2014

Yeah we need to switch to LooseVersion. I was going to do it in another PR.

@argriffing

This comment has been minimized.

Copy link

commented Feb 13, 2014

Apparently LooseVersion doesn't work for all of the alpha, beta, release candidate, development versions, etc. that are used by numpy and scipy, so this was recently written.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2014

Ah, thanks for the pointer, I hadn't seen that.

jseabold added a commit that referenced this pull request Apr 3, 2014

Merge pull request #1383 from jseabold/deprecate-rank
MAINT: Deprecate rank in favor of np.linalg.matrix_rank

@jseabold jseabold merged commit 29a3bce into statsmodels:master Apr 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:deprecate-rank branch Apr 3, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1383 from jseabold/deprecate-rank
MAINT: Deprecate rank in favor of np.linalg.matrix_rank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.