MAINT: Fix failing tests #1387

Merged
merged 5 commits into from Feb 20, 2014

Projects

None yet

3 participants

@jseabold
Member

This fixes some test failures I was seeing on my machine. There are still 8 errors related to ProbPlot. I fixed some of them, assuming I knew where the kwargs needed to be passed on. I don't know this code well anymore, so I'm not sure what the other keyword in the tests should do for ProbPlot.ppplot. @phobson any chance you can take a look at this or explain what is expected here? It should be an easy fix.

closes #1377

@phobson
Contributor
phobson commented Feb 13, 2014

Yes. This is definitely still on my radar. Hope to have something together soon.

@josef-pkt
Member

does 63bc263 fix #1377 ?

@jseabold
Member

It does, yeah. It should work before, through, and after that behavior change/bug. I knew I'd seen that failure somewhere...I'll edit the commit message.

@josef-pkt josef-pkt added the PR label Feb 19, 2014
@josef-pkt
Member

This fixes the test failures for me on py33 with pandas 0.13.1 and patsy 0.2.1

I have two test failures with numdiff now, that I didn't have in the previous run with master. I don't see anything in this PR that might be related. #1142

ready to merge

@jseabold jseabold merged commit 3f2a265 into statsmodels:master Feb 20, 2014

1 check passed

default The Travis CI build passed
Details
@jseabold jseabold deleted the jseabold:fix-tests branch Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment