BUG/BLD: exclude sandbox in relative path, not absolute #1458

Merged
merged 1 commit into from Mar 10, 2014

Projects

None yet

3 participants

@TomAugspurger
Contributor

Closes #1457

I didn't see any tests for setup.py, so I didn't include any. I can write a test for this function in a new file if you want. I've manually tested on a Mac for python 2.7 and 3.3

@josef-pkt josef-pkt added the build label Mar 10, 2014
@josef-pkt
Member

looks good, AFAIKS

how do you write a unit test for setup.py? I've never heard of it. Do you know a package with an example?

@TomAugspurger
Contributor

I'm not sure either. unittest is built around modules IIRC, so I'm not even sure that it's able to be tested. I was going to suggest moving the get_data_files function, but then we wouldn't be able to import it since statsmodels isn't installed at the time of setup. Famous last words, but this shouldn't break anything.

@jseabold jseabold merged commit 96824bf into statsmodels:master Mar 10, 2014

1 check passed

default The Travis CI build passed
Details
@josef-pkt josef-pkt added the PR label Mar 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment