Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/BLD: exclude sandbox in relative path, not absolute #1458

Merged
merged 1 commit into from Mar 10, 2014

Conversation

Projects
None yet
3 participants
@TomAugspurger
Copy link
Contributor

commented Mar 10, 2014

Closes #1457

I didn't see any tests for setup.py, so I didn't include any. I can write a test for this function in a new file if you want. I've manually tested on a Mac for python 2.7 and 3.3

@josef-pkt josef-pkt added the build label Mar 10, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Mar 10, 2014

looks good, AFAIKS

how do you write a unit test for setup.py? I've never heard of it. Do you know a package with an example?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2014

I'm not sure either. unittest is built around modules IIRC, so I'm not even sure that it's able to be tested. I was going to suggest moving the get_data_files function, but then we wouldn't be able to import it since statsmodels isn't installed at the time of setup. Famous last words, but this shouldn't break anything.

jseabold added a commit that referenced this pull request Mar 10, 2014

Merge pull request #1458 from TomAugspurger/sandbox-build
BUG/BLD: exclude sandbox in relative path, not absolute

@jseabold jseabold merged commit 96824bf into statsmodels:master Mar 10, 2014

1 check passed

default The Travis CI build passed
Details

@josef-pkt josef-pkt added the PR label Mar 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1458 from TomAugspurger/sandbox-build
BUG/BLD: exclude sandbox in relative path, not absolute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.