Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Improve warnings to avoid generic warnings messages #1510

Merged
merged 2 commits into from Apr 3, 2014

Conversation

Projects
None yet
4 participants
@bashtage
Copy link
Contributor

commented Mar 25, 2014

All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2014

Has a single file conflict with the test silence PR #1507, but I can rebase the one that goes in 2nd.

@jseabold

This comment has been minimized.

Copy link
Member

commented Apr 3, 2014

Ping us when you rebase on master.

Kevin Sheppard added some commits Mar 24, 2014

Kevin Sheppard
CLN: Improve warnings to avoid generic warnings messages
All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

Conflicts:
	statsmodels/tools/sm_exceptions.py
Kevin Sheppard
Added specific warnings in a couple of places where they were missing
Converted raise Warning to warning.warn

Made certain warnings had been imported in some modules where it was lazily
imported

Simplified warnings in GEE which was neither lazily imported nor imported
at the top of the file
@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2014

@jseabold I have rebased and squashed a small number of warnings that had escaped.

@coveralls

This comment has been minimized.

Copy link

commented Apr 3, 2014

Coverage Status

Coverage remained the same when pulling 3415486 on bashtage:warning-convert into 2762065 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 3, 2014

looks good to me

jseabold added a commit that referenced this pull request Apr 3, 2014

Merge pull request #1510 from bashtage/warning-convert
CLN: Improve warnings to avoid generic warnings messages

@jseabold jseabold merged commit 4164e54 into statsmodels:master Apr 3, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details

@bashtage bashtage deleted the bashtage:warning-convert branch Apr 3, 2014

@josef-pkt josef-pkt added the PR label Apr 14, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1510 from bashtage/warning-convert
CLN: Improve warnings to avoid generic warnings messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.