CLN: Improve warnings to avoid generic warnings messages #1510

Merged
merged 2 commits into from Apr 3, 2014

Projects

None yet

4 participants

@bashtage
Contributor

All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

@bashtage
Contributor

Has a single file conflict with the test silence PR #1507, but I can rebase the one that goes in 2nd.

@jseabold
Member
jseabold commented Apr 3, 2014

Ping us when you rebase on master.

Kevin Sheppard added some commits Mar 24, 2014
Kevin Sheppard CLN: Improve warnings to avoid generic warnings messages
All generic Warnings have been replaced with specific warnings, which have
been consolidated into sm_exceptions.py.

Conflicts:
	statsmodels/tools/sm_exceptions.py
f843122
Kevin Sheppard Added specific warnings in a couple of places where they were missing
Converted raise Warning to warning.warn

Made certain warnings had been imported in some modules where it was lazily
imported

Simplified warnings in GEE which was neither lazily imported nor imported
at the top of the file
3415486
@bashtage
Contributor
bashtage commented Apr 3, 2014

@jseabold I have rebased and squashed a small number of warnings that had escaped.

@coveralls

Coverage Status

Coverage remained the same when pulling 3415486 on bashtage:warning-convert into 2762065 on statsmodels:master.

@josef-pkt
Member

looks good to me

@jseabold jseabold merged commit 4164e54 into statsmodels:master Apr 3, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@bashtage bashtage deleted the bashtage:warning-convert branch Apr 3, 2014
@josef-pkt josef-pkt added the PR label Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment