Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Restores coveralls for a single build #1536

Merged
merged 6 commits into from Apr 2, 2014

Conversation

Projects
None yet
4 participants
@bashtage
Copy link
Contributor

commented Apr 1, 2014

Restores the coveralls coverage by changing the coveralls rc file
Limits coverage to the single mainstream run - Python 2.7 with NumPy 1.7 and SciPy 0.12

Kevin Sheppard added some commits Apr 1, 2014

Kevin Sheppard
Test coveralls issue removing if, then
Fixed coveragerc to allow anythin in */statsmodels/*
Changes for single coverage run
@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

@josef-pkt @jseabold This should fix the two issues related to coveralls identified in the previous PR.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

Thanks,
we have to wait a bit to hear back from travisci and coveralls, there are 3 testruns in the queue

as reminder: if there are no code changes, e.g. only docs, then we can also skip a test run [skip ci]
http://docs.travis-ci.com/user/how-to-skip-a-build/

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

Coverage is up 3% - presumably due to matplotlib testing.

https://coveralls.io/builds/645578

A hair away form 80 now.

Kevin Sheppard
Change test condition for coverage
Fix for missing font warning
@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

Looks like it is working as expected now.

https://coveralls.io/builds/646417

The repo root information in coveralls needs to be changed to reflect the changed system path.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

I updated the path on coverall.io
looks fine
(I haven't checked yet if we lost older files, but that doesn't matter much)

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

Yes, switching the path messes up the old coveralls reports
https://coveralls.io/files/165266251

I don't think anyone is looking at old coverage files, should be just a short transition problem.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

@jseabold
related:
do you know why we don't get coveralls.io emails and comments anymore? Did you change a setting? Or did coveralls.io turn it off because we complained about incorrect messages?

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

looks good to merge

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

I have been getting them occasionally in the past couple of days from builds using the old travis scripts. I do not get them for all builds that submit coverage though.

@jseabold

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

I didn't change anything. I don't know if they fixed the incorrect stuff or what. I don't pay attention to the coveralls stuff because it's very low signal to noise ratio given all the problems.

Kevin Sheppard
@coveralls

This comment has been minimized.

Copy link

commented Apr 1, 2014

Coverage Status

Coverage remained the same when pulling b7e91ca on bashtage:travis-miniconda into d991e25 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

Ok, we do get the coverage messages (again)

Can I hit the merge button?

@jseabold

This comment has been minimized.

Copy link
Member

commented Apr 1, 2014

Fine by me (I didn't look). Any chance on marking knownfail or fixing the GMM test failure noise?

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

One more build to simplify things. I also mark known fails.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

BTW, I have emails on. These were off before, any preferences here?

https://github.com/bashtage/statsmodels/blob/travis-miniconda/.travis.yml#L49

Kevin Sheppard
Marked known fails
Suppressed noise from matplotlib about .matplotlibrc location
@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2014

Github seems to be having problems, but it is passing...and so is complete. Ignores 3 SciPy 13 failures now.

I have restarted by githib-induced errors:

https://travis-ci.org/bashtage/statsmodels/builds/22058618

which are passing now.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2014

This really is finished now.

josef-pkt added a commit that referenced this pull request Apr 2, 2014

Merge pull request #1536 from bashtage/travis-miniconda
BUG: Restores coveralls for a single build

@josef-pkt josef-pkt merged commit b0e5b41 into statsmodels:master Apr 2, 2014

1 check passed

default The Travis CI build passed
Details
@josef-pkt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2014

merged, thanks

@bashtage bashtage deleted the bashtage:travis-miniconda branch Apr 2, 2014

@josef-pkt josef-pkt added the PR label Apr 14, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1536 from bashtage/travis-miniconda
BUG: Restores coveralls for a single build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.