Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gee maint 1528 rebased #1553

Merged
merged 10 commits into from Apr 9, 2014

Conversation

Projects
None yet
3 participants
@josef-pkt
Copy link
Member

commented Apr 4, 2014

possible PR for #1314 extras and #1528 rebased on current master

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2014

unfortunately during cherrypicking one author got switched

@@ -131,7 +128,7 @@ def update(self, beta, parent):

ngrp = len(resid)
residsq = np.outer(resid, resid)
scale += np.diag(residsq).sum()
scale += np.trace(residsq)

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Apr 7, 2014

Author Member

isn't this just (resid**2).sum()
instead of the nobs_i, nobs_i outer product

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Apr 7, 2014

Author Member

ignore this, residsq is used in the next line

@@ -644,31 +668,29 @@ def predict(self, params, exog=None, offset=None, linear=False):

return fitted

def _starting_params(self, starting_params):
def _starting_params(self):

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Apr 7, 2014

Author Member

general candidate for conistent renaming across models start_params
but not consistent in other models either

Returns:
--------
beta : array-like
The input parameter vector beta, expanded to the
mean_params : array-like

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Apr 7, 2014

Author Member

params_mean postfix ?
another term that we start to see more across models, and haven't settled on a name yet.

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Apr 7, 2014

Author Member

no reason to change here again, before we haven't settled on a name

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2014

rebased again on current master,
should be ready for green button merge when TravisCI reports back.

(The nice thing about isolated imports: I haven't yet recompiled my working checkout for the new cython code, and everything else still works, so far)

@coveralls

This comment has been minimized.

Copy link

commented Apr 9, 2014

Coverage Status

Coverage remained the same when pulling 23ead84 on josef-pkt:gee_maint_1528_rebased into cd7f0d0 on statsmodels:master.

josef-pkt added a commit that referenced this pull request Apr 9, 2014

@josef-pkt josef-pkt merged commit bf6639c into statsmodels:master Apr 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2014

I forgot the commit code in the merge message again
REF/ENH

@josef-pkt josef-pkt added the PR label Apr 14, 2014

@josef-pkt josef-pkt deleted the josef-pkt:gee_maint_1528_rebased branch Jul 10, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.