Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix math. #1574

Merged
merged 1 commit into from Sep 21, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Apr 8, 2014

Small typo in the math. I'm not going to merge this yet, because I'm not sure about the new IPython signature and whether it will change when each user makes a commit. Do others see a signature update when they just open and save the notebook?

http://ipython.org/ipython-doc/dev/notebook/security.html#the-details-of-trust

Note also that IPython doesn't support Python 2.6 anymore. I don't know if that means these notebooks can't be run on 2.6 anymore either.

@bashtage

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2014

I updated all notebooks to work in Python3 using IPython 2, and they all still work in Python 2.6 using IPython 1.1.0. Obviously if they incorporate IPython 2 features, then you these will not work in Python 2.6 + IPython < 2.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2014

So the new metadata fields are just ignored in IPython < 2?

@bashtage

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2014

Yes. When the JSON is deserialized I'm sure it is just a key that no code looks for.

The best solution would be to not store the signature on githib

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2014

I don't know how to save the notebook without a signature. IIUC, you can't.
It's a unique key between user (users?) and notebook. That's why I'm
wondering if it changes from machine to machine. I'm not planning to remove
them by hand every time I make a small edit in a notebook. Maybe a git
post-commit hook scrub is possible.

@bashtage

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2014

I’m pretty sure it changes per installation.

Removing it would require a simple cleaner script.

From: Skipper Seabold [mailto:notifications@github.com]
Sent: Tuesday, April 8, 2014 6:27 PM
To: statsmodels/statsmodels
Cc: Kevin Sheppard
Subject: Re: [statsmodels] DOC: Fix math. (#1574)

I don't know how to save the notebook without a signature. IIUC, you can't.
It's a unique key between user (users?) and notebook. That's why I'm
wondering if it changes from machine to machine. I'm not planning to remove
them by hand every time I make a small edit in a notebook. Maybe a git
post-commit hook scrub is possible.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1574#issuecomment-39876901.

@josef-pkt josef-pkt added PR labels Apr 14, 2014

@jseabold jseabold force-pushed the jseabold:fix-math branch from 6d0847c to 53c9920 Sep 21, 2014

jseabold added a commit that referenced this pull request Sep 21, 2014

@jseabold jseabold merged commit d722dca into statsmodels:master Sep 21, 2014

0 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build is in progress
Details

@jseabold jseabold deleted the jseabold:fix-math branch Sep 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.