BUG/ENH Fix negbin exposure #1611 #1612

Merged
merged 3 commits into from Apr 21, 2014

Projects

None yet

3 participants

@josef-pkt
Member

fixes #1611

this uses predict() instead of hardcoded exp(exog dot params)

enables one test from #1610 will cause merge conflict
rebase on top of #1610 can drop the second commit

@coveralls

Coverage Status

Coverage remained the same when pulling 9298a57 on josef-pkt:fix_negbin_exposure_1611 into e7e018a on statsmodels:master.

@jseabold
Member

You can remove the TODO at line 660 with this.

@josef-pkt
Member

rebased on master and force pushed

@josef-pkt
Member

all green, merging

todo: followup more unit tests, needs tests for nb1 with exposure Stata dispersion(constant)

@josef-pkt josef-pkt merged commit a42463d into statsmodels:master Apr 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@josef-pkt josef-pkt deleted the josef-pkt:fix_negbin_exposure_1611 branch Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment