Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ENH Fix negbin exposure #1611 #1612

Merged
merged 3 commits into from Apr 21, 2014

Conversation

Projects
None yet
3 participants
@josef-pkt
Copy link
Member

commented Apr 20, 2014

fixes #1611

this uses predict() instead of hardcoded exp(exog dot params)

enables one test from #1610 will cause merge conflict
rebase on top of #1610 can drop the second commit

@josef-pkt josef-pkt added PR labels Apr 20, 2014

@coveralls

This comment has been minimized.

Copy link

commented Apr 20, 2014

Coverage Status

Coverage remained the same when pulling 9298a57 on josef-pkt:fix_negbin_exposure_1611 into e7e018a on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member

commented Apr 20, 2014

You can remove the TODO at line 660 with this.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2014

rebased on master and force pushed

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Apr 21, 2014

all green, merging

todo: followup more unit tests, needs tests for nb1 with exposure Stata dispersion(constant)

josef-pkt added a commit that referenced this pull request Apr 21, 2014

@josef-pkt josef-pkt merged commit a42463d into statsmodels:master Apr 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:fix_negbin_exposure_1611 branch Apr 21, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.