Summary2 still doesn't have even minimal smoke tests, apparently. This snuck in during the 2to3 refactor.
Yes, you're right. I might have a bit of time to invest in this in the next few weeks, but my degree of effort will likely be contingent on whether there's a plan for this thing. Useless code with smoke tests is still useless ;)
I discovered it because I was trying to see whether summary2 fixed #1584 easily. If it does, then it's a pro for using it. No tests means not production ready, though.
The answer is no it doesn't, since this relies on SimpleTable anyway for the parameters table.
As TravisCI shows, there is the same smoke test for summary2() as for summary()
The problem then is that the repr swallowed the error, so I guess smoketests aren't enough.
: <repr(<statsmodels.iolib.summary2.Summary at 0x2751c710>) failed: pandas.core.indexing.IndexingError: Too many indexers>
IndexingError: Too many indexers
The problem was that the key error was inside a try ... except, and the exception is swallowed.
smoke tests are not enough for this
try ... except
The problem was that the refactor changed .keys() to iteritems which yields tuples not a key.
This error being ignored is what caused the indexing error (the info ended up being empty), but it was never swallowed. It's only swallowed by repr as I showed above.
right, it caught AttributeError but not KeyError, I misread
summary2 has three blanket try ... except:
try ... except:
BUG: Fix refactor victim