Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotplot kshedden rebased of 1294 #1681

Merged
merged 20 commits into from May 21, 2014

Conversation

Projects
None yet
3 participants
@josef-pkt
Copy link
Member

commented May 21, 2014

rebased version of pull #1294

Only one merge conflict in version0.6.rst

ready to merge if TravisCI is green in all pythons

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented May 21, 2014

This is not on common py2 py3 codebase yet. Needs fixing for python 3

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2014

Coverage Status

Coverage increased (+0.2%) when pulling d3f1750 on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented May 21, 2014

py3 compat is easy
python 2.6 doesn't have dictionary comprehension
(some changes could be reversed later, looks prettier without py 2.6 compatibility)

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2014

Coverage Status

Coverage increased (+0.2%) when pulling b92bddd on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

horizontal=True, ax=None):
"""
Produce a dotplot similar in style to those in Cleveland's
"Visualizing Data" book. These are also known as "forest plots".

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt May 21, 2014

Author Member

summary line should be one line

If True (default), the lines are drawn horizontally, otherwise
they are drawn vertically.
ax : matplotlib.axes
The axes on which the dotplot is drawn. If None, a new axes

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt May 21, 2014

Author Member

'a new figure is created' ?

the same length whenever present.
Examples
--------

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt May 21, 2014

Author Member

docstring should have a working example that displays a plot in the docs

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2014

Coverage Status

Coverage increased (+0.2%) when pulling 2215682 on josef-pkt:dotplot_kshedden_rebased into ede3157 on statsmodels:master.

josef-pkt added a commit that referenced this pull request May 21, 2014

@josef-pkt josef-pkt merged commit bbb0f8d into statsmodels:master May 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:dotplot_kshedden_rebased branch May 21, 2014

@josef-pkt josef-pkt added PR labels May 21, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone May 21, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.