Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kshedden mixed rebased of #1398 #1688

Merged
merged 59 commits into from May 24, 2014

Conversation

Projects
None yet
3 participants
@josef-pkt
Copy link
Member

commented May 24, 2014

rebased and python 3 compat changes of PR #1398 mixed effects models

kshedden added some commits Feb 17, 2014

@josef-pkt josef-pkt referenced this pull request May 24, 2014

Closed

WIP linear mixed models #1398

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented May 24, 2014

I'm getting one suspicious warning running the test suite:

E:\Josef\eclipsegworkspace\statsmodels-git\statsmodels-all-new2_py27\statsmodels\statsmodels\regression\lme.py:551: ComplexWarning: Casting complex values to real discards the imaginary part
  cov_re[ix] = re_params

Ran 53 tests in 104.467s

@coveralls

This comment has been minimized.

Copy link

commented May 24, 2014

Coverage Status

Coverage increased (+0.15%) when pulling b04bddf on josef-pkt:kshedden_mixed_rebased into 3adaa1a on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented May 24, 2014

merging this, rebase looks good from spot checking

needs a follow-up and a new issue
Test coverage has gaps (EM?) https://coveralls.io/files/205591508 78%
also I didn't see any tests for results other than the basic params, cov and scales.

params_table in summary uses normal distribution, do we have df_resid, df_model?
(is there a small sample option for inference?)

from_formula should be overwritten to take a formula for exog_re (only a designmatrix), I guess.

predict? unconditional mean, BLUE for individual ?

josef-pkt added a commit that referenced this pull request May 24, 2014

@josef-pkt josef-pkt merged commit 6ff0f30 into statsmodels:master May 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:kshedden_mixed_rebased branch Jul 10, 2014

@josef-pkt josef-pkt added the PR label Aug 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.