OSL Example: redundant cell in example removed #1692

Merged
merged 1 commit into from May 25, 2014

Projects

None yet

3 participants

@ericchiang
Contributor

Noticed that code cells 3 and 4 are the same for the ordinary least squares example

osl_redundant_cell

@josef-pkt
Member

Hi, thanks for finding this.

One problem with notebooks is that it changes the hash each time.

Can you amend your commit and remove the hash change on line 4?. remove chunk and force push

I only know how to do it with git gui.

@coveralls

Coverage Status

Coverage remained the same when pulling 44b9cb0 on EricChiang:master into 6ff0f30 on statsmodels:master.

@ericchiang
Contributor

@josef-pkt Just did it in an editor. Let me know if there are any other changes that need to be made.

@josef-pkt
Member

looks good to me now, merging

Thank you,

BTW: You are using your master instead of a feature branch.

@josef-pkt josef-pkt merged commit 5bf8a7d into statsmodels:master May 25, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@ericchiang
Contributor

sweet

my b on the branching, thanks for the heads up

@coveralls

Coverage Status

Coverage remained the same when pulling 5d22d53 on EricChiang:master into 6ff0f30 on statsmodels:master.

@josef-pkt josef-pkt added the PR label Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment