Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSL Example: redundant cell in example removed #1692

Merged
merged 1 commit into from May 25, 2014

Conversation

Projects
None yet
3 participants
@ericchiang
Copy link
Contributor

commented May 25, 2014

Noticed that code cells 3 and 4 are the same for the ordinary least squares example

osl_redundant_cell

@josef-pkt

This comment has been minimized.

Copy link
Member

commented May 25, 2014

Hi, thanks for finding this.

One problem with notebooks is that it changes the hash each time.

Can you amend your commit and remove the hash change on line 4?. remove chunk and force push

I only know how to do it with git gui.

@coveralls

This comment has been minimized.

Copy link

commented May 25, 2014

Coverage Status

Coverage remained the same when pulling 44b9cb0 on EricChiang:master into 6ff0f30 on statsmodels:master.

@ericchiang

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2014

@josef-pkt Just did it in an editor. Let me know if there are any other changes that need to be made.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented May 25, 2014

looks good to me now, merging

Thank you,

BTW: You are using your master instead of a feature branch.

josef-pkt added a commit that referenced this pull request May 25, 2014

Merge pull request #1692 from EricChiang/master
DOC: OLS Example: redundant cell in example removed

@josef-pkt josef-pkt merged commit 5bf8a7d into statsmodels:master May 25, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@ericchiang

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2014

sweet

my b on the branching, thanks for the heads up

@coveralls

This comment has been minimized.

Copy link

commented May 25, 2014

Coverage Status

Coverage remained the same when pulling 5d22d53 on EricChiang:master into 6ff0f30 on statsmodels:master.

@josef-pkt josef-pkt added the PR label Aug 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1692 from EricChiang/master
DOC: OLS Example: redundant cell in example removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.