Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix faulty logic. Do not raise when missing='raise' and no missing data. #1701

Merged
merged 3 commits into from May 29, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented May 28, 2014

closes #1700

@jseabold

This comment has been minimized.

Copy link
Member Author

commented May 28, 2014

Mark for backport if we ever get to the 0.5.1 release?

@coveralls

This comment has been minimized.

Copy link

commented May 28, 2014

Coverage Status

Changes Unknown when pulling 100e990 on jseabold:fix-1700 into * on statsmodels:master*.

@josef-pkt

This comment has been minimized.

Copy link

commented on statsmodels/base/tests/test_data.py in d9ca83b May 28, 2014

"assert_doesnot_raise" test (not really smoke in lack of a real test) :)

@josef-pkt

This comment has been minimized.

Copy link
Member

commented May 28, 2014

looks good.

Trying to understand a bit the logic in the missing value handling.
It uses pandas.isnull which does not check for inf. related to #1642

@jseabold

This comment has been minimized.

Copy link
Member Author

commented May 28, 2014

It does if you ask it to #1450

@josef-pkt

This comment has been minimized.

Copy link
Member

commented May 28, 2014

good cross-link, I didn't remember this.

@jseabold jseabold added this to the 0.5.1 milestone May 29, 2014

jseabold added a commit that referenced this pull request May 29, 2014

Merge pull request #1701 from jseabold/fix-1700
BUG: Fix faulty logic. Do not raise when missing='raise' and no missing data.

@jseabold jseabold merged commit e4326b7 into statsmodels:master May 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:fix-1700 branch May 29, 2014

@josef-pkt josef-pkt added the PR label Aug 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1701 from jseabold/fix-1700
BUG: Fix faulty logic. Do not raise when missing='raise' and no missing data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.