BUG: Fix faulty logic. Do not raise when missing='raise' and no missing data. #1701

Merged
merged 3 commits into from May 29, 2014

Projects

None yet

3 participants

@jseabold
Member

closes #1700

@jseabold
Member

Mark for backport if we ever get to the 0.5.1 release?

@coveralls

Coverage Status

Changes Unknown when pulling 100e990 on jseabold:fix-1700 into * on statsmodels:master*.

@josef-pkt

"assert_doesnot_raise" test (not really smoke in lack of a real test) :)

@josef-pkt
Member

looks good.

Trying to understand a bit the logic in the missing value handling.
It uses pandas.isnull which does not check for inf. related to #1642

@jseabold
Member

It does if you ask it to #1450

@josef-pkt
Member

good cross-link, I didn't remember this.

@jseabold jseabold added this to the 0.5.1 milestone May 29, 2014
@jseabold jseabold merged commit e4326b7 into statsmodels:master May 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jseabold jseabold deleted the jseabold:fix-1700 branch May 29, 2014
@josef-pkt josef-pkt added the PR label Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment