BLD: Made build extensions more flexible #1709

Merged
merged 1 commit into from Jun 6, 2014

Projects

None yet

5 participants

@ChadFulton
Member

I need to include 'libraries' and 'libraries_lib' arguments to the Extension( ... ) setup for #1698. This pull request just allows each extension to define additional **kwargs in the Extension call.

@coveralls

Coverage Status

Coverage remained the same when pulling 60b07f4 on ChadFulton:setup into e4326b7 on statsmodels:master.

@rgommers rgommers commented on an outdated diff May 30, 2014
- sources.extend(data.get('sources', []))
+ destdir = ".".join(os.path.dirname(data["name"]).split("/"))
+ del data['name']
@rgommers
rgommers May 30, 2014 Member

del always looks fishy to me, data.remove('name') is better.

@rgommers
Member

What's libraries_lib for by the way? I can't remember that being used anywhere.
EDIT: never mind, saw the discussion on gh-1698.

@rgommers rgommers added the build label May 30, 2014
@coveralls

Coverage Status

Coverage remained the same when pulling 093c43c on ChadFulton:setup into e4326b7 on statsmodels:master.

@ChadFulton
Member

This is a very similar approach to what numpy does, see e.g. https://github.com/numpy/numpy/blob/master/numpy/distutils/misc_util.py#L1448

@jseabold
Member
jseabold commented Jun 5, 2014

Can you go ahead and squash this to one commit? Not strictly necessary but maybe appropriate here.

@ChadFulton
Member

Squashed it wrong apparently, sorry, will try again.

@jseabold
Member
jseabold commented Jun 5, 2014

I usually do

git rebase -i HEAD~3

Then follow the instructions there. Just change commit to SQUASH (or whatever it says) in your editor.

@ChadFulton
Member

That worked, thanks. I always screw up the repository on my first try.

@coveralls

Coverage Status

Coverage remained the same when pulling 1b4efc3 on ChadFulton:setup into 2c3eb6d on statsmodels:master.

@coveralls

Coverage Status

Coverage remained the same when pulling 1b4efc3 on ChadFulton:setup into 2c3eb6d on statsmodels:master.

@jseabold jseabold merged commit 9da5dc5 into statsmodels:master Jun 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Jun 6, 2014
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 43c036b
@josef-pkt josef-pkt added the PR label Aug 11, 2014
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Oct 6, 2014
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 87b35db
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Oct 6, 2014
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 f3c540f
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Nov 4, 2014
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 7b2b8eb
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Jan 4, 2015
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 5692dfd
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Feb 12, 2015
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 8a1a0b9
@ChadFulton ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Feb 12, 2015
@ChadFulton ChadFulton FIX: Fixed build due to statsmodels/statsmodels#1709 662644d
@ChadFulton ChadFulton deleted the ChadFulton:setup branch Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment