Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Made build extensions more flexible #1709

Merged
merged 1 commit into from Jun 6, 2014

Conversation

Projects
None yet
5 participants
@ChadFulton
Copy link
Member

commented May 30, 2014

I need to include 'libraries' and 'libraries_lib' arguments to the Extension( ... ) setup for #1698. This pull request just allows each extension to define additional **kwargs in the Extension call.

@coveralls

This comment has been minimized.

Copy link

commented May 30, 2014

Coverage Status

Coverage remained the same when pulling 60b07f4 on ChadFulton:setup into e4326b7 on statsmodels:master.

setup.py Outdated

sources.extend(data.get('sources', []))
destdir = ".".join(os.path.dirname(data["name"]).split("/"))
del data['name']

This comment has been minimized.

Copy link
@rgommers

rgommers May 30, 2014

Member

del always looks fishy to me, data.remove('name') is better.

@rgommers

This comment has been minimized.

Copy link
Member

commented May 30, 2014

What's libraries_lib for by the way? I can't remember that being used anywhere.
EDIT: never mind, saw the discussion on gh-1698.

@coveralls

This comment has been minimized.

Copy link

commented May 30, 2014

Coverage Status

Coverage remained the same when pulling 093c43c on ChadFulton:setup into e4326b7 on statsmodels:master.

@ChadFulton

This comment has been minimized.

Copy link
Member Author

commented May 30, 2014

This is a very similar approach to what numpy does, see e.g. https://github.com/numpy/numpy/blob/master/numpy/distutils/misc_util.py#L1448

@jseabold

This comment has been minimized.

Copy link
Member

commented Jun 5, 2014

Can you go ahead and squash this to one commit? Not strictly necessary but maybe appropriate here.

@ChadFulton

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2014

Squashed it wrong apparently, sorry, will try again.

@jseabold

This comment has been minimized.

Copy link
Member

commented Jun 5, 2014

I usually do

git rebase -i HEAD~3

Then follow the instructions there. Just change commit to SQUASH (or whatever it says) in your editor.

@ChadFulton

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2014

That worked, thanks. I always screw up the repository on my first try.

@coveralls

This comment has been minimized.

Copy link

commented Jun 5, 2014

Coverage Status

Coverage remained the same when pulling 1b4efc3 on ChadFulton:setup into 2c3eb6d on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Jun 5, 2014

Coverage Status

Coverage remained the same when pulling 1b4efc3 on ChadFulton:setup into 2c3eb6d on statsmodels:master.

jseabold added a commit that referenced this pull request Jun 6, 2014

Merge pull request #1709 from ChadFulton/setup
BLD: Made build extensions more flexible

@jseabold jseabold merged commit 9da5dc5 into statsmodels:master Jun 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Jun 6, 2014

@josef-pkt josef-pkt added the PR label Aug 11, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1709 from ChadFulton/setup
BLD: Made build extensions more flexible

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Oct 6, 2014

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Oct 6, 2014

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Nov 4, 2014

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Jan 4, 2015

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Feb 12, 2015

ChadFulton added a commit to ChadFulton/statsmodels that referenced this pull request Feb 12, 2015

@ChadFulton ChadFulton deleted the ChadFulton:setup branch Jan 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.