Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phreg 1312 rebased #1825

Merged
merged 38 commits into from Jul 11, 2014

Conversation

Projects
None yet
3 participants
@josef-pkt
Copy link
Member

commented Jul 11, 2014

rebased version of #1312

removed duplicate commits with interactive rebase dropping those commits

unit tests for test_phreg pass locally (py 2.7)

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2014

Coverage Status

Coverage increased (+0.35%) when pulling c12b56c on josef-pkt:phreg_1312_rebased into 1697f70 on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2014

Coverage Status

Coverage increased (+0.35%) when pulling 22a6113 on josef-pkt:phreg_1312_rebased into 1697f70 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2014

I squashed the first several commits that were still changing test data files, and two commits that had identical commit message to the preceding commits

moved to statsmodels.duration

renamed module to hazard_regression.py
renamed class to PHReg instead of PHreg (capitalize first R)
(forgot to rename to PHRegResults, same capitalized R)

not yet: add to api.py and rst docs

@kshedden is the module name ok? other changes ok?

(I'll try to find the time to merge tonight)

@kshedden

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2014

Thanks, all looks good to me.

On Sat, Jul 12, 2014 at 3:43 AM, Josef Perktold notifications@github.com
wrote:

I squashed the first several commits that were still changing test data
files, and two commits that had identical commit message to the preceding
commits

moved to statsmodels.duration

renamed module to hazard_regression.py
renamed class to PHReg instead of PHreg (capitalize first R)
(forgot to rename to PHRegResults, same capitalized R)

not yet: add to api.py and rst docs

@kshedden https://github.com/kshedden is the module name ok? other
changes ok?

(I'll try to find the time to merge tonight)


Reply to this email directly or view it on GitHub
#1825 (comment)
.

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2014

Coverage Status

Coverage remained the same when pulling d8e27f4 on josef-pkt:phreg_1312_rebased into 70a3921 on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2014

Coverage Status

Coverage remained the same when pulling 925358c on josef-pkt:phreg_1312_rebased into 70a3921 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2014

all green, merging

needs some follow-up review

josef-pkt added a commit that referenced this pull request Jul 11, 2014

Merge pull request #1825 from josef-pkt/phreg_1312_rebased
ENH: Cox Proportional Hazard Model, Phreg rebased closes #1312

@josef-pkt josef-pkt merged commit 31e30a3 into statsmodels:master Jul 11, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:phreg_1312_rebased branch Jul 11, 2014

@coveralls

This comment has been minimized.

Copy link

commented Jul 11, 2014

Coverage Status

Coverage increased (+0.35%) when pulling adf02bc on josef-pkt:phreg_1312_rebased into 70a3921 on statsmodels:master.

@josef-pkt josef-pkt added the PR label Aug 11, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 24, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1825 from josef-pkt/phreg_1312_rebased
ENH: Cox Proportional Hazard Model, Phreg rebased closes statsmodels#1312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.