Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_spg_optim returns history of objective function values #1856

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
2 participants
@kshedden
Copy link
Contributor

commented Jul 30, 2014

This PR attaches the sequence of all objective function values visited by _spg_optim to the results that it returns. It also adds tests for the convergence status of cor_nearest_factor.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Jul 30, 2014

I was also trying out different things today, but didn't see anything that would be a likely cause.
ARPACK svds on Ubuntu 32 might need to be checking.
I was trying out different starting values and different lam_min and lam_max.

One thing I also added in my version is to check the number of iterations:
adding 'iterations': itr to the return Bunch in _spg_optim.

I was a bit surprised that it takes around 1000 iterations.

@josef-pkt josef-pkt added the PR label Aug 1, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

I'm merging this as another trial to figure out what's going on.
(I didn't have time to add my changes.)

possible problems
start value: uses ARPACK svds which changed across scipy versions
convergence criterium: When I was fiddling with lam_min and lam_max, the iterations stopped too early. (not sure whether it was supposed to or not)

josef-pkt added a commit that referenced this pull request Aug 1, 2014

Merge pull request #1856 from kshedden/cor_nearest_maint2
REF/TST _spg_optim returns history of objective function values

@josef-pkt josef-pkt merged commit b257c7c into statsmodels:master Aug 1, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt added the type-test label Aug 24, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 24, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1856 from kshedden/cor_nearest_maint2
REF/TST _spg_optim returns history of objective function values

@kshedden kshedden deleted the kshedden:cor_nearest_maint2 branch Sep 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.