Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Don't use negative indexing with k_ar == 0. Closes #1858. #1859

Merged
merged 1 commit into from Aug 20, 2014

Conversation

Projects
None yet
3 participants

@josef-pkt josef-pkt added the PR label Aug 1, 2014

@@ -639,6 +639,7 @@ def geterrors(self, params):
return errors.squeeze()

def predict(self, params, start=None, end=None, exog=None, dynamic=False):
import ipdb; ipdb.set_trace()

This comment has been minimized.

Copy link
@josef-pkt

josef-pkt Aug 17, 2014

Member

left over from testing

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 17, 2014

TravisCI fails with ImportError: No module named ipdb

needs cleanup and rebase.
Is there test coverage for this?

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2014

Fixed debugger import.

@coveralls

This comment has been minimized.

Copy link

commented Aug 18, 2014

Coverage Status

Coverage remained the same when pulling 19f4d2e on jseabold:arimax-forecast-bug into 93efca1 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 20, 2014

can you rebase and force push?
or I do it locally and merge.

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 20, 2014

@jseabold jseabold force-pushed the jseabold:arimax-forecast-bug branch from 19f4d2e to 92a494a Aug 20, 2014

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2014

Not sure why, but I rebased.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 20, 2014

Now, it shows up as rebased in the network graph. (before it looked more like an ammend)

merge when TravisCI is green?

@coveralls

This comment has been minimized.

Copy link

commented Aug 20, 2014

Coverage Status

Coverage remained the same when pulling 92a494a on jseabold:arimax-forecast-bug into b3c35b7 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Aug 20, 2014

merging

josef-pkt added a commit that referenced this pull request Aug 20, 2014

Merge pull request #1859 from jseabold/arimax-forecast-bug
BUG: Don't use negative indexing with k_ar == 0. Closes #1858.

@josef-pkt josef-pkt merged commit ab1a57b into statsmodels:master Aug 20, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1859 from jseabold/arimax-forecast-bug
BUG: Don't use negative indexing with k_ar == 0. Closes statsmodels#1858.

@jseabold jseabold deleted the jseabold:arimax-forecast-bug branch Sep 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.