BUG: Don't use negative indexing with k_ar == 0. Closes #1858. #1859

Merged
merged 1 commit into from Aug 20, 2014

Projects

None yet

3 participants

@josef-pkt josef-pkt added the PR label Aug 1, 2014
@josef-pkt josef-pkt commented on an outdated diff Aug 17, 2014
statsmodels/tsa/arima_model.py
@@ -639,6 +639,7 @@ def geterrors(self, params):
return errors.squeeze()
def predict(self, params, start=None, end=None, exog=None, dynamic=False):
+ import ipdb; ipdb.set_trace()
@josef-pkt
josef-pkt Aug 17, 2014 Member

left over from testing

@josef-pkt
Member

TravisCI fails with ImportError: No module named ipdb

needs cleanup and rebase.
Is there test coverage for this?

@jseabold
Member

Fixed debugger import.

@coveralls

Coverage Status

Coverage remained the same when pulling 19f4d2e on jseabold:arimax-forecast-bug into 93efca1 on statsmodels:master.

@josef-pkt
Member

can you rebase and force push?
or I do it locally and merge.

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 20, 2014
@jseabold jseabold BUG: Don't use negative indexing with k_ar == 0. Closes #1858.
92a494a
@jseabold
Member

Not sure why, but I rebased.

@josef-pkt
Member

Now, it shows up as rebased in the network graph. (before it looked more like an ammend)

merge when TravisCI is green?

@coveralls

Coverage Status

Coverage remained the same when pulling 92a494a on jseabold:arimax-forecast-bug into b3c35b7 on statsmodels:master.

@josef-pkt
Member

merging

@josef-pkt josef-pkt merged commit ab1a57b into statsmodels:master Aug 20, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@jseabold jseabold deleted the jseabold:arimax-forecast-bug branch Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment