TST: fix _infer_freq for pandas .14+ compat #1872

Merged
merged 1 commit into from Aug 6, 2014

Projects

None yet

3 participants

@TomAugspurger
Contributor

closes #1822
some discussion over at pandas: pandas-dev/pandas#7922

Basically pandas 0.14 fixed a bug with DatetimeIndex's raising an AttributeError if you
tried to access its freqstr attribute when it doesn't have a frequency.
The tests previously relied on having the freqstr attribute implying that freqstr was not None.

@TomAugspurger TomAugspurger TST: fix _infer_freq for pandas .14+ compat
pandas 0.14 fixed a bug with DatetimeIndex's
freqstr attribute. Previously relied on
having the freqstr attribute implying that freqstr
was not none.
14e293d
@coveralls

Coverage Status

Coverage increased (+0.0%) when pulling 14e293d on TomAugspurger:infer_freq_pandas_break into 8709f00 on statsmodels:master.

@josef-pkt
Member

fix looks short, just to know where to make the change.

@TomAugspurger Thanks, that relieves Skipper from fixing problems with pandas compatibility..
Do you know if this might cause any problems with older versions of pandas. TravisCI is green, so it should be fine with the tested versions.

@jseabold Any opinion?
I would just merge this and see whether it fixes the problems on python-xy ubuntu testing.
Since it's fixing failing tests, test coverage should be fine.

@josef-pkt josef-pkt merged commit 2e806fc into statsmodels:master Aug 6, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@josef-pkt
Member

@TomAugspurger Thank you

We'll see tomorrow whether python-xy is fine.
https://code.launchpad.net/~pythonxy/+recipe/statsmodels-daily-current

@josef-pkt
Member

very good all freq test failures are gone.

(now we just have categorical.labels incompatibility with pandas left )

@josef-pkt josef-pkt added the PR label Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment