Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: corr_nearest_factor, more informative tests #1885

Merged
merged 1 commit into from Aug 14, 2014

Conversation

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Aug 14, 2014

this add more test for parts of the result and for sparse.svds to get more information about the failing test in #1850

result will be visible in pythonxy 32-bit Ubuntu

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2014

@kshedden this is another try to get at the test failure in corr_nearest_factor
My main guess right now is the starting value or the initial stepsize.

I think adding a start_factor=None keyword would be helpful, unless you think there is no usecase for it.

@coveralls

This comment has been minimized.

Copy link

commented Aug 14, 2014

Coverage Status

Coverage increased (+0.01%) when pulling 5ec9fc5 on josef-pkt:corr_nearest_factor_1850 into 20c59d2 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2014

merging, more when the test results are in

josef-pkt added a commit that referenced this pull request Aug 14, 2014

Merge pull request #1885 from josef-pkt/corr_nearest_factor_1850
TST: corr_nearest_factor, more informative tests

@josef-pkt josef-pkt merged commit 0c5e6c2 into statsmodels:master Aug 14, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2014

see #1850 for continuation

@josef-pkt josef-pkt added this to the 0.6 milestone Aug 24, 2014

@josef-pkt josef-pkt removed the PR label Aug 24, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1885 from josef-pkt/corr_nearest_facto…
…r_1850

TST: corr_nearest_factor, more informative tests

@josef-pkt josef-pkt deleted the josef-pkt:corr_nearest_factor_1850 branch Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.