Bug pandas compat asserts #1887

Merged
merged 2 commits into from Aug 16, 2014

Projects

None yet

2 participants

@josef-pkt
Member

fixes test asserts that are failing because of changes in pandas master, and numpy.testing.assert_equal doesn't work anymore.

e.g. https://launchpadlibrarian.net/182311320/buildlog_ubuntu-utopic-i386.statsmodels_0.6.0~ppa18~revno-1690~ubuntu14.10.1_UPLOADING.txt.gz

this adds a statsmodels.tools.testing module with an assert_equal wrapper for the corresponding numpy and pandas functions.

changes 1 test in test_arima so that desired is an Index not a list of strings.

statsmodels.tools.testing is currently used only for one case, namely to have backwards compatibility with assert_index_equal and assert_equal for older pandas

josef-pkt added some commits Aug 15, 2014
@josef-pkt josef-pkt ENH: add tools.testing module for asserts (numpy, pandas compat wrapper) 175470e
@josef-pkt josef-pkt TST: pandas compat: change asserts (failing with pandas master for 0.15)
461e926
@josef-pkt
Member

@jseabold Do you want to have a look here? this is usually your area.

@josef-pkt
Member

I tested it locally with pandas master, and it should remove the last test failures with pandas master in the pythonxy Ubuntu testing.

@coveralls

Coverage Status

Coverage decreased (-0.0%) when pulling 461e926 on josef-pkt:BUG_pandas_compat_asserts into eeb1d97 on statsmodels:master.

@josef-pkt
Member

merging to get Ubuntu test results

@josef-pkt josef-pkt merged commit 6f5ddd5 into statsmodels:master Aug 16, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@josef-pkt josef-pkt deleted the josef-pkt:BUG_pandas_compat_asserts branch Aug 16, 2014
@josef-pkt josef-pkt added a commit to josef-pkt/statsmodels that referenced this pull request Aug 17, 2014
@josef-pkt josef-pkt TST: fix assert_equal for pandas index, (was left out of PR #1887) dcb7435
@PierreBdR PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014
@josef-pkt josef-pkt TST: fix assert_equal for pandas index, (was left out of PR #1887) d1f0480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment