Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug pandas compat asserts #1887

Merged
merged 2 commits into from Aug 16, 2014

Conversation

Projects
None yet
2 participants
@josef-pkt
Copy link
Member

commented Aug 15, 2014

fixes test asserts that are failing because of changes in pandas master, and numpy.testing.assert_equal doesn't work anymore.

e.g. https://launchpadlibrarian.net/182311320/buildlog_ubuntu-utopic-i386.statsmodels_0.6.0~ppa18~revno-1690~ubuntu14.10.1_UPLOADING.txt.gz

this adds a statsmodels.tools.testing module with an assert_equal wrapper for the corresponding numpy and pandas functions.

changes 1 test in test_arima so that desired is an Index not a list of strings.

statsmodels.tools.testing is currently used only for one case, namely to have backwards compatibility with assert_index_equal and assert_equal for older pandas

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2014

@jseabold Do you want to have a look here? this is usually your area.

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2014

I tested it locally with pandas master, and it should remove the last test failures with pandas master in the pythonxy Ubuntu testing.

@coveralls

This comment has been minimized.

Copy link

commented Aug 16, 2014

Coverage Status

Coverage decreased (-0.0%) when pulling 461e926 on josef-pkt:BUG_pandas_compat_asserts into eeb1d97 on statsmodels:master.

@josef-pkt josef-pkt added PR labels Aug 16, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2014

merging to get Ubuntu test results

josef-pkt added a commit that referenced this pull request Aug 16, 2014

Merge pull request #1887 from josef-pkt/BUG_pandas_compat_asserts
ENH/TST: pandas compat asserts, new statsmodels.tools.testing

@josef-pkt josef-pkt merged commit 6f5ddd5 into statsmodels:master Aug 16, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@josef-pkt josef-pkt deleted the josef-pkt:BUG_pandas_compat_asserts branch Aug 16, 2014

josef-pkt added a commit to josef-pkt/statsmodels that referenced this pull request Aug 17, 2014

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Merge pull request statsmodels#1887 from josef-pkt/BUG_pandas_compat_…
…asserts

ENH/TST: pandas compat asserts, new statsmodels.tools.testing

PierreBdR pushed a commit to PierreBdR/statsmodels that referenced this pull request Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.