Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Binstar build files #1939

Merged
merged 1 commit into from Sep 20, 2014

Conversation

Projects
None yet
4 participants
@bashtage
Copy link
Contributor

commented Aug 28, 2014

Includes the files necessary to build conda packages and upload to binstar for Windows and Linux (OSX should also work, but untested)

The binstar repo has been created here:

https://binstar.org/statsmodels/statsmodels

@bashtage bashtage force-pushed the bashtage:conda-binstar branch from 780754a to 75aa8b9 Aug 28, 2014

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2014

Coverage Status

Coverage remained the same when pulling 780754a on bashtage:conda-binstar into 957a43e on statsmodels:master.

@bashtage bashtage force-pushed the bashtage:conda-binstar branch 2 times, most recently from 50c5fce to 397d055 Aug 28, 2014

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2014

Coverage Status

Coverage remained the same when pulling 397d055 on bashtage:conda-binstar into 9ce1605 on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member

commented Sep 16, 2014

lgtm. Should we get this in and add the linux script to the docs build machine and the windows to the windows build machine?

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

I haven't looked at any of the binstar details, and I would merge without looking.

two issues:
needs rebase now, because README.txt has been renamed in master

the second, I would prefer to put the binstar folder in the (top) tools directory, so we can keep the top-level of statsmodels cleaner and simpler.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2014

Sounds reasonable. Clean is good. Any suggestions as to a location?

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2014

I guess tools would be the best place. I think I can clean it up a bit too to make it simpler.

Perhaps tools should have a build folder that would contain all things related to building?

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

just one level down https://github.com/statsmodels/statsmodels/tree/master/tools
that's where build and other supporting tools are that are not part of the code.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

most of tools is related to building (plus some extra helper functions). I think one extra folder level, like binstar should be enough.

build is a dangerous name for a folder, because build is the name for the generated folder that is used for building/compiling the package or docs, and is usually deleted during cleaning of extra, generated files.

@bashtage bashtage force-pushed the bashtage:conda-binstar branch 2 times, most recently from fc35e2c to 5e62a05 Sep 19, 2014

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 5e62a05 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@bashtage bashtage force-pushed the bashtage:conda-binstar branch from 5e62a05 to 29084fa Sep 19, 2014

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 5e62a05 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 29084fa on bashtage:conda-binstar into ea554cc on statsmodels:master.

@bashtage bashtage force-pushed the bashtage:conda-binstar branch 3 times, most recently from 40cfefd to a90f805 Sep 19, 2014

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 40cfefd on bashtage:conda-binstar into ea554cc on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 19, 2014

ping me when it's finished and I will merge

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling a90f805 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2014

Going to add some improvements to handle additional configurations so may be until the end of the weekend.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling cd8d922 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling cd8d922 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling cd8d922 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling aec0ed7 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 3ae1d70 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 3ae1d70 on bashtage:conda-binstar into ea554cc on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 19, 2014

Coverage Status

Coverage remained the same when pulling 3ae1d70 on bashtage:conda-binstar into ea554cc on statsmodels:master.

Kevin Sheppard
ENH: Binstar build files
Files requires to build and automatically upload binary files to binstar
which will allow recent version to be installed by binary-only users of
conda.

[skip ci]

@bashtage bashtage force-pushed the bashtage:conda-binstar branch from 3ae1d70 to 2de9fa7 Sep 20, 2014

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2014

@josef-pkt Ready.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

Thanks, merging

josef-pkt added a commit that referenced this pull request Sep 20, 2014

Merge pull request #1939 from bashtage/conda-binstar
BLD/ENH: Binstar build files

@josef-pkt josef-pkt merged commit 715f850 into statsmodels:master Sep 20, 2014

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2014

On a mildly interesting note, the Python 3.4 has been getting some downloads. This is due to build error that 0.5 has against 3.4 which means that statsmodels isn't available to 3.4 users from Anaconda.

@josef-pkt josef-pkt added the build label Sep 20, 2014

@josef-pkt josef-pkt added this to the 0.6 milestone Sep 20, 2014

@bashtage bashtage deleted the bashtage:conda-binstar branch Sep 20, 2014

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

Where do you see the download statistic?

There was a Twitter message a few days ago, that statsmodels should now be available for 3.4 for Anaconda. https://twitter.com/ContinuumIO/status/511629809420484608

Gohlke also has Windows binaries of 0.5 for python 3.4
http://www.lfd.uci.edu/~gohlke/pythonlibs/#statsmodels

@jseabold

This comment has been minimized.

Copy link
Member

commented Sep 20, 2014

Yeah I had a back and forth with Aaron, he regenerated the cython files for 3.4, so it should work now.

@bashtage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2014

The stats are visible here:

https://binstar.org/statsmodels/statsmodels/files

They are all 0 since I have to delete before uploading a file with the same name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.