Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Rename jac -> score_obs. Closes #1785. #1982

Merged
merged 2 commits into from Sep 23, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Sep 21, 2014

see #1785

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

Don't merge this yet.

My guess is that this might break some user code. I need to check if we need to keep jac as alias, which I thought we do.

@coveralls

This comment has been minimized.

Copy link

commented Sep 21, 2014

Coverage Status

Coverage decreased (-0.0%) when pulling 5c41b60 on jseabold:jac-rename into 0529da7 on statsmodels:master.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2014

I deprecated it. Need to add to release notes, but I suspect they'll need a lot of work anyway.

@coveralls

This comment has been minimized.

Copy link

commented Sep 21, 2014

Coverage Status

Coverage increased (+0.01%) when pulling 0f24c10 on jseabold:jac-rename into 0529da7 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

Looks good to me, shouldn't cause any compatibility problems

merging

josef-pkt added a commit that referenced this pull request Sep 23, 2014

Merge pull request #1982 from jseabold/jac-rename
REF: Rename jac -> score_obs. Closes #1785.

@josef-pkt josef-pkt merged commit 2fcc5ae into statsmodels:master Sep 23, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.