BLD: Let pip/setuptools handle dependencies that aren't installed at all. #2000

Merged
merged 3 commits into from Sep 25, 2014

Projects

None yet

3 participants

@jseabold
Member

Closes gh-1897 and gh-1425.

Rebased version of #1902.

@jseabold jseabold added this to the 0.6 milestone Sep 25, 2014
@jseabold jseabold added PR build labels Sep 25, 2014
@jseabold jseabold merged commit 1520fe0 into statsmodels:master Sep 25, 2014
@jseabold jseabold deleted the jseabold:build-deps branch Sep 25, 2014
@cel4
cel4 commented Sep 25, 2014

@jseabold: Have you checked if installing in an empty environment works now? I think at least for me it did not work for some odd reason.

@jseabold
Member

No, admittedly I haven't, though I checked that the principle worked here [1].

Can you post the full build log somewhere?

[1] mwaskom/seaborn#300

@jseabold
Member

Trying a clean build now.

@jseabold
Member

Yes, this looks to have problems. I'll look into it.

@jseabold
Member

Thanks for the report. I see the issue. I'll push a fix.

@jseabold
Member

To be concrete the problem is that when you do a pip install source_tarball or from git, this is what's in sys.argv for pip 1.5.4.

['-c', 'egg_info', '--egg-base', 'pip-egg-info']

Hence our 'no frills' check fails. @rgommers Is this a pip version issue with what you've wrote or did this never work?

@rgommers
Member
rgommers commented Dec 3, 2014

Hi, sorry about not responding earlier. Now working through my backlog. I thought it worked before, but I can't remember for sure. Looks like the issue is resolved now. Thanks for finishing up @jseabold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment