Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Let pip/setuptools handle dependencies that aren't installed at all. #2000

Merged
merged 3 commits into from Sep 25, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Sep 25, 2014

Closes gh-1897 and gh-1425.

Rebased version of #1902.

@jseabold jseabold added this to the 0.6 milestone Sep 25, 2014

@jseabold jseabold added PR build labels Sep 25, 2014

jseabold added a commit that referenced this pull request Sep 25, 2014

Merge pull request #2000 from jseabold/build-deps
BLD: Let pip/setuptools handle dependencies that aren't installed at all.

@jseabold jseabold merged commit 1520fe0 into statsmodels:master Sep 25, 2014

@jseabold jseabold deleted the jseabold:build-deps branch Sep 25, 2014

@cel4

This comment has been minimized.

Copy link

commented Sep 25, 2014

@jseabold: Have you checked if installing in an empty environment works now? I think at least for me it did not work for some odd reason.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

No, admittedly I haven't, though I checked that the principle worked here [1].

Can you post the full build log somewhere?

[1] mwaskom/seaborn#300

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

Trying a clean build now.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

Yes, this looks to have problems. I'll look into it.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

Thanks for the report. I see the issue. I'll push a fix.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2014

To be concrete the problem is that when you do a pip install source_tarball or from git, this is what's in sys.argv for pip 1.5.4.

['-c', 'egg_info', '--egg-base', 'pip-egg-info']

Hence our 'no frills' check fails. @rgommers Is this a pip version issue with what you've wrote or did this never work?

@rgommers

This comment has been minimized.

Copy link
Member

commented Dec 3, 2014

Hi, sorry about not responding earlier. Now working through my backlog. I thought it worked before, but I can't remember for sure. Looks like the issue is resolved now. Thanks for finishing up @jseabold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.