Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Better error message on object dtype #2013

Merged
merged 2 commits into from Sep 26, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Sep 26, 2014

Alternatively, we could just try to cast to float but since we're not systematically handling dtypes I preferred to just fail early and let the user know to check their data.

Closes #880. Should also close #1875.

Can look at fixing #1210 in this PR too.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Sep 26, 2014

looks good, I wasn't sure where this check should be added.

(we still have the same problem with auxiliary arrays, other arrays in model.__init__)

@jseabold jseabold force-pushed the jseabold:object-dtype branch from eb55b15 to 00f6558 Sep 26, 2014

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2014

I'm going to look at the others with the GEE/New models grouping missing stuff.

@coveralls

This comment has been minimized.

Copy link

commented Sep 26, 2014

Coverage Status

Coverage increased (+0.01%) when pulling 00f6558 on jseabold:object-dtype into 7f42939 on statsmodels:master.

@coveralls

This comment has been minimized.

Copy link

commented Sep 26, 2014

Coverage Status

Coverage increased (+0.01%) when pulling 00f6558 on jseabold:object-dtype into 7f42939 on statsmodels:master.

jseabold added a commit that referenced this pull request Sep 26, 2014

Merge pull request #2013 from jseabold/object-dtype
ENH: Better error message on object dtype

@jseabold jseabold merged commit 2e5d13a into statsmodels:master Sep 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:object-dtype branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.