Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix numerical issues in links and families. #2028

Merged
merged 6 commits into from Oct 6, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Oct 6, 2014

Closes #2024.

@jseabold jseabold added this to the 0.6 milestone Oct 6, 2014

@coveralls

This comment has been minimized.

Copy link

commented Oct 6, 2014

Coverage Status

Coverage increased (+0.0%) when pulling 4e99fea on jseabold:invlogit-stable into cfebe9a on statsmodels:master.

jseabold added a commit that referenced this pull request Oct 6, 2014

Merge pull request #2028 from jseabold/invlogit-stable
ENH: Fix numerical issues in links and families.

@jseabold jseabold merged commit 850e0e4 into statsmodels:master Oct 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@@ -208,13 +204,13 @@ def inverse_deriv(self, z):
"""
t = np.exp(z)
return t/(1+t)**2
return t/(1 + t)**2

This comment has been minimized.

Copy link
@brentp

brentp Oct 9, 2014

Should this use t = np.exp(-z) andreturn 1 / (1 + t)**2` ?

@jseabold jseabold deleted the jseabold:invlogit-stable branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.