Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Handle missing for extra data with formulas #2034

Merged
merged 9 commits into from Oct 10, 2014

Conversation

Projects
None yet
3 participants
@jseabold
Copy link
Member

commented Oct 8, 2014

This should handle all the missing data issues when going through patsy. I know this is mentioned in #1877. Probably elsewhere, but I have to run.

TODO

  • Add to release notes

@jseabold jseabold added this to the 0.6 milestone Oct 8, 2014

@coveralls

This comment has been minimized.

Copy link

commented Oct 8, 2014

Coverage Status

Coverage increased (+0.06%) when pulling d5a971f on jseabold:fix-1877 into f65e8c0 on statsmodels:master.

@josef-pkt

This comment has been minimized.

Copy link
Member

commented Oct 9, 2014

I'm not really a fan of making these fundamental changes just before a release with no time to gain experience with how well it works.

But going through large part of the changes, I don't see any problem. But I also don't understand what all the implications are.

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2014

This is fixing a priority high bug release blocker. What else are we supposed to do?

@jseabold jseabold force-pushed the jseabold:fix-1877 branch from 9fdd124 to f43a92a Oct 9, 2014

@jseabold

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2014

I'm going to go ahead and merge this shortly. Hopefully, any issues that the tests don't catch will come out in a release candidate or we can do a micro release as needed. In any event I think it's an improvement over the status quo of definitely doesn't work.

jseabold added a commit that referenced this pull request Oct 10, 2014

Merge pull request #2034 from jseabold/fix-1877
ENH: Handle missing for extra data with formulas

@jseabold jseabold merged commit 4f55df8 into statsmodels:master Oct 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jseabold jseabold deleted the jseabold:fix-1877 branch Oct 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.