ENH: Handle missing for extra data with formulas #2034

merged 9 commits into from Oct 10, 2014


None yet

3 participants

jseabold commented Oct 8, 2014

This should handle all the missing data issues when going through patsy. I know this is mentioned in #1877. Probably elsewhere, but I have to run.


  • Add to release notes
@jseabold jseabold added this to the 0.6 milestone Oct 8, 2014

Coverage Status

Coverage increased (+0.06%) when pulling d5a971f on jseabold:fix-1877 into f65e8c0 on statsmodels:master.


I'm not really a fan of making these fundamental changes just before a release with no time to gain experience with how well it works.

But going through large part of the changes, I don't see any problem. But I also don't understand what all the implications are.

jseabold commented Oct 9, 2014

This is fixing a priority high bug release blocker. What else are we supposed to do?

jseabold commented Oct 9, 2014

I'm going to go ahead and merge this shortly. Hopefully, any issues that the tests don't catch will come out in a release candidate or we can do a micro release as needed. In any event I think it's an improvement over the status quo of definitely doesn't work.

@jseabold jseabold merged commit 4f55df8 into statsmodels:master Oct 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
@jseabold jseabold deleted the jseabold:fix-1877 branch Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment