Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove string_types in favor of str #5972

Merged
merged 3 commits into from Jul 18, 2019

Conversation

bashtage
Copy link
Member

Remove old alias

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #5972 into master will increase coverage by <.01%.
The diff coverage is 80.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5972      +/-   ##
==========================================
+ Coverage   83.23%   83.23%   +<.01%     
==========================================
  Files         610      610              
  Lines       95699    95657      -42     
  Branches    10482    10483       +1     
==========================================
- Hits        79654    79624      -30     
+ Misses      13639    13627      -12     
  Partials     2406     2406
Impacted Files Coverage Δ
statsmodels/graphics/plot_grids.py 0% <ø> (ø) ⬆️
...odels/sandbox/panel/sandwich_covariance_generic.py 0% <ø> (ø) ⬆️
statsmodels/genmod/families/tests/test_link.py 100% <ø> (ø) ⬆️
statsmodels/sandbox/tsa/example_arma.py 0% <ø> (ø) ⬆️
statsmodels/stats/contrast.py 80.44% <ø> (-0.09%) ⬇️
statsmodels/distributions/mixture_rvs.py 65.21% <ø> (-0.5%) ⬇️
statsmodels/tools/linalg.py 73.07% <ø> (-0.51%) ⬇️
statsmodels/stats/multitest.py 93.44% <ø> (-0.03%) ⬇️
statsmodels/tools/data.py 72.88% <ø> (-0.46%) ⬇️
statsmodels/stats/_adnorm.py 80.7% <ø> (-0.34%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e5e92d...7252192. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 18, 2019

Coverage Status

Coverage increased (+1.0e-05%) to 85.748% when pulling 7252192 on bashtage:string_types into 3e5e92d on statsmodels:master.

@jbrockmendel
Copy link
Contributor

Looks like a complaint somewhere about asstr2

@bashtage bashtage force-pushed the string_types branch 2 times, most recently from 24027e7 to 15a5472 Compare July 18, 2019 15:34
Remove keyword substitutions and other simple replacements
Remove the remainder of the easy to replace shims
@bashtage bashtage merged commit c860d30 into statsmodels:master Jul 18, 2019
@bashtage bashtage deleted the string_types branch July 18, 2019 18:41
@bashtage bashtage added this to closed in 0.11 Aug 2, 2019
@bashtage bashtage added this to the 0.11 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.11
  
closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants