Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Small fix ups for modernized size #6052

Merged
merged 1 commit into from Aug 1, 2019

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Aug 1, 2019

Some small tweaks to catch missed elements

  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in master and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/master -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

Some small tweaks to catch missed elements
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #6052 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         607      607           
  Lines       96404    96404           
  Branches    10471    10471           
=======================================
  Hits        80565    80565           
  Misses      13458    13458           
  Partials     2381     2381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f7a2b...89d5c29. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.04% when pulling 89d5c29 on bashtage:css-fix into 60f7a2b on statsmodels:master.

@bashtage bashtage merged commit fa1c1ae into statsmodels:master Aug 1, 2019
@bashtage bashtage deleted the css-fix branch August 1, 2019 11:04
@bashtage bashtage added this to closed in 0.11 Aug 2, 2019
@bashtage bashtage added this to the 0.11 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.11
  
closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants