ENH: Prefer to_offset to get_offset. Closes #964. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class _freq_to_pandas_class(object): | ||
| # being lazy, don't want to replace dictionary below | ||
| def __getitem__(self, key): | ||
| return get_offset(key) | ||
| return to_offset(key) | ||
| _freq_to_pandas = _freq_to_pandas_class() | ||
| except ImportError, err: |
There was a problem hiding this comment.
Are you using err, if not drop it, just noise that needs to be py version adjusted
|
I have no idea about these parts. Merge it, and it will go through version compatibility testing. |
|
Ok. Rebased on top of parser fix for 0.8.x. Merging. |
jseabold
added a commit
that referenced
this pull request
Jul 25, 2013
ENH: Prefer to_offset to get_offset. Closes #964.
PierreBdR
pushed a commit
to PierreBdR/statsmodels
that referenced
this pull request
Sep 2, 2014
ENH: Prefer to_offset to get_offset. Closes statsmodels#964.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I lied about not wanting to get anything else in. This is a two line fix that will greatly improve our frequency handling, cut down on SO questions, and works fine with pandas 0.8.1. Requires the parser.parse changes to work on 0.8.1.