misc, tests, diagnostic #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased on master added some delinting |
|
@jseabold This needs to go into 0.5.0 |
|
Ok. Will wait for Travis. Let me know if/when to merge. |
| if alternative in ['two-sided', '2s', 'smaller']: | ||
| crit_low = stats.t.ppf(alpha_, df) | ||
| pow_ += stats.nct._cdf(crit_low, df, d*np.sqrt(nobs)) | ||
| #print crit_low, df, d*np.sqrt(nobs) | ||
| if np.isnan(crit_upp): |
There was a problem hiding this comment.
copy-paste error and not running the tests
also missing an any()
fixed
|
Merge? |
|
go ahead, all green (I also ran the tests this time with the oldest versions.) |
jseabold
added a commit
that referenced
this pull request
Jul 31, 2013
TST/BUG: Bug fixes and tests for diagnostic and pylint fixes.
PierreBdR
pushed a commit
to PierreBdR/statsmodels
that referenced
this pull request
Sep 2, 2014
TST/BUG: Bug fixes and tests for diagnostic and pylint fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #962: add tests, surprisingly all tests pass without changes to the functions even though they use wrapped results instead of
._results(tested only with pandas 0.7.3 so far)