Skip to content
This repository was archived by the owner on Aug 13, 2024. It is now read-only.

Commit 229227e

Browse files
committed
chore: rename method
1 parent 00fe5ce commit 229227e

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

gui/components/community/create_community_popups.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def _open_logo_file_dialog(self, attempt: int = 2):
9090
@allure.step('Set community logo')
9191
def logo(self, kwargs: dict):
9292
self._open_logo_file_dialog().open_file(kwargs['fp'])
93-
PictureEditPopup().wait_until_appears().make_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
93+
PictureEditPopup().wait_until_appears().set_zoom_shift_for_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
9494

9595
@property
9696
@allure.step('Get community banner')
@@ -101,7 +101,7 @@ def banner(self):
101101
def banner(self, kwargs: dict):
102102
self._add_banner_button.click()
103103
OpenFileDialog().wait_until_appears().open_file(kwargs['fp'])
104-
PictureEditPopup().wait_until_appears().make_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
104+
PictureEditPopup().wait_until_appears().set_zoom_shift_for_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
105105

106106
@allure.step('Set community logo without file upload dialog')
107107
def set_logo_without_file_upload_dialog(self, path):
@@ -164,9 +164,9 @@ def open_next_form(self):
164164
@allure.step('Create community without file upload dialog usage')
165165
def create_community(self, kwargs):
166166
self.set_logo_without_file_upload_dialog(kwargs['logo']['fp'])
167-
PictureEditPopup().make_picture(None, None)
167+
PictureEditPopup().set_zoom_shift_for_picture(None, None)
168168
self.set_banner_without_file_upload_dialog(kwargs['banner']['fp'])
169-
PictureEditPopup().make_picture(None, None)
169+
PictureEditPopup().set_zoom_shift_for_picture(None, None)
170170
for key in list(kwargs):
171171
if key in ['intro', 'outro'] and self._next_button.is_visible:
172172
self._next_button.click()

gui/components/picture_edit_popup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def __init__(self):
2323
self._slider_handler = QObject(names.o_DropShadow)
2424

2525
@allure.step('Make picture')
26-
def make_picture(
26+
def set_zoom_shift_for_picture(
2727
self,
2828
zoom: int = None,
2929
shift: shift_image = None

gui/screens/community_settings.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def logo(self) -> Image:
152152
def logo(self, kwargs: dict):
153153
self._add_logo_button.click()
154154
OpenFileDialog().wait_until_appears().open_file(kwargs['fp'])
155-
PictureEditPopup().wait_until_appears().make_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
155+
PictureEditPopup().wait_until_appears().set_zoom_shift_for_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
156156

157157
@property
158158
@allure.step('Get community banner')
@@ -163,7 +163,7 @@ def banner(self) -> Image:
163163
def banner(self, kwargs: dict):
164164
self._add_banner_button.click()
165165
OpenFileDialog().wait_until_appears().open_file(kwargs['fp'])
166-
PictureEditPopup().wait_until_appears().make_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
166+
PictureEditPopup().wait_until_appears().set_zoom_shift_for_picture(kwargs.get('zoom', None), kwargs.get('shift', None))
167167

168168
@allure.step('Set community logo without file upload dialog')
169169
def set_logo_without_file_upload_dialog(self, path):
@@ -233,9 +233,9 @@ def pin_message_checkbox_state(self) -> bool:
233233
@allure.step('Edit community')
234234
def edit(self, kwargs):
235235
self.set_logo_without_file_upload_dialog(kwargs['logo']['fp'])
236-
PictureEditPopup().make_picture(None, None)
236+
PictureEditPopup().set_zoom_shift_for_picture(None, None)
237237
self.set_banner_without_file_upload_dialog(kwargs['banner']['fp'])
238-
PictureEditPopup().make_picture(None, None)
238+
PictureEditPopup().set_zoom_shift_for_picture(None, None)
239239
for key in list(kwargs):
240240
setattr(self, key, kwargs.get(key))
241241
self._save_changes_button.click()

tests/onboarding/test_onboarding_generate_new_keys.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def test_generate_new_keys(main_window, keys_screen, user_name: str, password, u
6262
profile_view.set_profile_picture(configs.testpath.TEST_IMAGES / user_image)
6363
#if user_image is not None:
6464
# profile_picture_popup = profile_view.set_user_image(configs.testpath.TEST_IMAGES / user_image)
65-
PictureEditPopup().make_picture(zoom=zoom, shift=shift)
65+
PictureEditPopup().set_zoom_shift_for_picture(zoom=zoom, shift=shift)
6666
# TODO: find a way to verify the picture is there (changed to the custom one)
6767
assert profile_view.get_profile_image is not None, f'Profile picture was not set / applied'
6868
assert profile_view.is_identicon_ring_visible, f'Identicon ring is not present when it should'

0 commit comments

Comments
 (0)